From: Andrew Morton <akpm@linux-foundation.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: yur@emcraft.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] shmem: respect MAX_LFS_FILESIZE
Date: Thu, 9 Apr 2009 16:36:10 -0700 [thread overview]
Message-ID: <20090409163610.8619bfc7.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0904062155090.21044@blonde.anvils>
On Mon, 6 Apr 2009 21:56:13 +0100 (BST)
Hugh Dickins <hugh@veritas.com> wrote:
> Question: couldn't the 32-bit kernel's MAX_LFS_FILESIZE be almost doubled?
> It limits the pagecache index to a signed long, but we use an unsigned long.
I expect it would be OK, yes. The only failure mode I can think of is
if someone is using signed long as a pagecache index and I'd be pretty
surprised if we've made that mistake anywhere. The potential for goofs
is higher down in filesystems, but they shouldn't be using pagecache
indices much at all.
Of course it does invite people to write applications which then fail
on older kernels, but such is life.
next prev parent reply other threads:[~2009-04-09 23:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-06 20:54 [PATCH 1/3] shmem: fix division by zero Hugh Dickins
2009-04-06 20:56 ` [PATCH 2/3] shmem: respect MAX_LFS_FILESIZE Hugh Dickins
2009-04-09 23:36 ` Andrew Morton [this message]
2009-04-10 9:28 ` Hugh Dickins
2009-04-06 21:01 ` [PATCH 3/3] powerpc: allow 256kB pages with SHMEM Hugh Dickins
2009-04-07 3:28 ` Paul Mackerras
2009-04-07 6:10 ` Hugh Dickins
2009-04-09 23:34 ` Andrew Morton
2009-04-10 8:58 ` Hugh Dickins
2009-04-16 16:50 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090409163610.8619bfc7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yur@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox