From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Ingo Molnar <mingo@elte.hu>, Tejun Heo <tj@kernel.org>,
Mike Travis <travis@sgi.com>,
Christoph Lameter <cl@linux-foundation.org>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] unbreak alpha percpu
Date: Fri, 10 Apr 2009 17:50:30 +0100 [thread overview]
Message-ID: <20090410165030.GQ26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0904100915010.4583@localhost.localdomain>
On Fri, Apr 10, 2009 at 09:21:08AM -0700, Linus Torvalds wrote:
>
> Hmm. I certainly personally _much_ prefer this version.
>
> It looks like this actually simplifies things for S390 too (no more
> simple_identifier_##var games), and generally just looks better. And
> seeing that the S390 special case is no longer S390-specific is also a
> good sign, imho.
simple_identifier_##var has been debris from back when Ingo forced
s390 to use asm-generic/percpu.h; if you look at it, you'll see that
a) it hadn't worked (look at the argument list carefully) and
b) get_cpu_var() has the working version anyway
Less obvious part is that if it actually *would* work, we'd be screwed -
unlike get_cpu_var() this sucker is called for things that are not
simple variables; didn't happen for alpha, but did for s390.
IOW, that's just an old piece of junk that got removed now.
next prev parent reply other threads:[~2009-04-10 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-10 15:12 [PATCH] unbreak alpha percpu Al Viro
2009-04-10 15:47 ` Al Viro
2009-04-10 16:21 ` Linus Torvalds
2009-04-10 16:50 ` Al Viro [this message]
2009-04-10 17:05 ` Al Viro
2009-04-10 17:14 ` Al Viro
2009-04-10 18:05 ` Ivan Kokshaysky
2009-04-10 18:20 ` Linus Torvalds
2009-04-10 18:43 ` Tejun Heo
2009-04-10 19:02 ` Tejun Heo
2009-04-10 19:34 ` Ingo Molnar
2009-04-10 19:40 ` [GIT PULL] percpu + mutex fixes Ingo Molnar
2009-04-16 10:21 ` Al Viro
2009-04-14 7:45 ` [PATCH] unbreak alpha percpu Martin Schwidefsky
2009-04-14 9:01 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090410165030.GQ26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=cl@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=schwidefsky@de.ibm.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox