public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Jike Song <albcamus@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	torvalds@osdl.org, akpm@linux-foundation.org,
	linux-am33-list@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [GIT PULL] MN10300: Move arch headers to arch dir
Date: Sat, 11 Apr 2009 09:55:49 +0200	[thread overview]
Message-ID: <20090411075549.GA30873@uranus.ravnborg.org> (raw)
In-Reply-To: <20090411064300.GT26366@ZenIV.linux.org.uk>

On Sat, Apr 11, 2009 at 07:43:00AM +0100, Al Viro wrote:
> On Sat, Apr 11, 2009 at 07:45:16AM +0200, Sam Ravnborg wrote:
> > On Sat, Apr 11, 2009 at 11:42:01AM +0800, Jike Song wrote:
> > > On Sat, Apr 11, 2009 at 3:25 AM, Sam Ravnborg <sam@ravnborg.org> wrote:
> > > >
> > > > .gitignore is left in include/asm-mn10300.
> > > >
> > > > As the content of that file is obsoleted by your last patch it can safely be deleted.
> > > > Linus - can I ask you to do so?
> > > >
> > > >        Sam
> > > 
> > > off topic: there is also a .gitignore left in include/asm-arm.
> > But its there for a reason.
> > Arm generates mach-types.h and it should be ignored.
> > 
> > include/asm-arm is no longer a sensible place for these files,
> > but for now I have no better place for them so they will
> > stay there for a while.
> 
> How about a single directory for *all* generated headers?  Only linux/version.h
> has many places including it and even that can be dealt with for a moment with
> linux/version.h consisting of #include <gen/version.h>.  The rest doesn't
> need anything like that even for transition period - too few includes to care.

So you suggest: include/gen/

asm-offsets.h, mach-types.h and version.h is the ones with the highest count.

And version.h is an exported header which we cannot move in our exported
set of headers. Fortunately I have just checked in a patch so we can specify
an alternative destination when exporting so this should deal with version.h.

asm-offsets.h and mach-types.h require a small helper file as you suggest,
otherwise it would be a _huge_ patch.

We can later migrate more generated files to this location.
(autoconf.h, config/* etc).

	Sam


  reply	other threads:[~2009-04-11  7:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-10 13:42 [GIT PULL] MN10300: Move arch headers to arch dir David Howells
2009-04-10 19:25 ` Sam Ravnborg
2009-04-10 22:07   ` [GIT PULL] MN10300: Remove obsolete include/asm-mn10300/.gitignore David Howells
2009-04-11  3:42   ` [GIT PULL] MN10300: Move arch headers to arch dir Jike Song
2009-04-11  5:45     ` Sam Ravnborg
2009-04-11  6:43       ` Al Viro
2009-04-11  7:55         ` Sam Ravnborg [this message]
2009-04-11 15:39           ` Al Viro
2009-04-11 20:44             ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090411075549.GA30873@uranus.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@linux-foundation.org \
    --cc=albcamus@gmail.com \
    --cc=dhowells@redhat.com \
    --cc=linux-am33-list@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=torvalds@osdl.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox