Re: [PATCH] netfilter: use per-CPU r**ursive lock {XV}

Linus Torvalds
2009-04-27T23:15:27Z

On Mon, 27 Apr 2009, Linus Torvalds wrote:
>
> BTW: THIS IS TOTALLY UNTESTED.

Gaah. I should have read through it one more time before sending.

> static inline void xt_info_rdunlock_bh(void)
> {
> struct xt_info_lock *lock;
>
> lock = &__get_cpu_var(xt_info_locks);
> if (!--lock->readers)
> spin_unlock(&lock->lock);
> }

This one was missing the "local_bh_enable()" at the end.

There may be other bugs, but that's the one I noticed immediately when
reading what I sent out. Oops.

Linus