From: Andrew Morton <akpm@linux-foundation.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: mingo@elte.hu, Valdis.Kletnieks@vt.edu, travis@sgi.com,
linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org,
rusty@rustcorp.com.au, davej@redhat.com, lenb@kernel.org
Subject: Re: mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu
Date: Mon, 13 Apr 2009 11:49:32 -0700 [thread overview]
Message-ID: <20090413114932.44b47910.akpm@linux-foundation.org> (raw)
In-Reply-To: <alpine.LFD.2.00.0904131040350.4583@localhost.localdomain>
On Mon, 13 Apr 2009 10:45:45 -0700 (PDT)
Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
>
> On Mon, 13 Apr 2009, Andrew Morton wrote:
> >
> > static void drv_write(struct drv_cmd *cmd)
> > {
> > - unsigned int i;
> > + unsigned int cpu;
> >
> > - for_each_cpu(i, cmd->mask) {
> > - work_on_cpu(i, do_drv_write, cmd);
> > - }
> > + for_each_cpu(cpu, cmd->mask)
> > + smp_call_function_single(cpu, do_drv_write, cmd, 1);
>
> Ok, that's just -wrong-.
>
> Doesn't anybody else see anything odd in doing
>
> for_each_cpu(cpu, cmd->mask)
> smp_call_function_single(cpu, ..);
>
> and react to it?
>
> IOW, why not just do
>
> smp_call_function_many(cmd->mask, do_drv_write, cmd, 1);
>
> here?
>
Didn't know it existed :(
next prev parent reply other threads:[~2009-04-13 18:55 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200904100922.n3A9MOIV013828@imap1.linux-foundation.org>
2009-04-10 19:53 ` mmotm 2009-04-10-02-21 uploaded (shmem) Randy Dunlap
2009-04-10 20:00 ` Andrew Morton
2009-04-10 20:04 ` Randy Dunlap
2009-04-10 20:16 ` Hugh Dickins
2009-04-11 13:22 ` mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu Valdis.Kletnieks
2009-04-13 16:04 ` Linus Torvalds
2009-04-13 16:34 ` Mike Galbraith
2009-04-13 17:18 ` Ingo Molnar
2009-04-13 17:27 ` Andrew Morton
2009-04-13 17:41 ` Ingo Molnar
2009-04-13 17:45 ` Linus Torvalds
2009-04-13 18:11 ` Ingo Molnar
2009-04-13 18:49 ` Andrew Morton [this message]
2009-04-13 19:03 ` Jeremy Fitzhardinge
2009-04-13 19:03 ` Dave Jones
2009-04-13 19:40 ` Ingo Molnar
2009-04-13 19:27 ` Valdis.Kletnieks
2009-04-13 23:50 ` Linus Torvalds
2009-04-14 0:31 ` Andrew Morton
2009-04-15 8:15 ` Ali Gholami Rudi
2009-04-15 8:34 ` Andrew Morton
2009-04-15 9:08 ` Ali Gholami Rudi
2009-04-15 14:45 ` Linus Torvalds
2009-04-14 12:42 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413114932.44b47910.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=davej@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mm-commits@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox