From: Alexander van Heukelum <heukelum@mailshack.com>
To: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Cc: Cyrill Gorcunov <gorcunov@openvz.org>, heukelum@fastmail.fm
Subject: [PATCH] Fix warnings after: x86: apic - introduce imcr_ helpers
Date: Mon, 13 Apr 2009 17:39:24 +0200 [thread overview]
Message-ID: <20090413153924.GA20287@mailshack.com> (raw)
Impact: fix compiler warnings
The patch "introduce imcr_ helpers" introduced good comments, but
also a few compile warnings. This fixes it.
Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
Acked-by: Cyrill Gorcunov <gorcunov@openvz.org>
---
Hi Ingo,
Cyrill forgot to refresh the patches :).
Greetings,
Alexander
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 054f604..c3c57b2 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -107,7 +107,7 @@ static int enabled_via_apicbase;
* the BIOS or the operating system must switch out of
* PIC Mode by changing the IMCR.
*/
-static inline imcr_pic_to_apic(void)
+static inline void imcr_pic_to_apic(void)
{
/* select IMCR register */
outb(0x70, 0x22);
@@ -115,7 +115,7 @@ static inline imcr_pic_to_apic(void)
outb(0x01, 0x23);
}
-static inline imcr_apic_to_pic(void)
+static inline void imcr_apic_to_pic(void)
{
/* select IMCR register */
outb(0x70, 0x22);
next reply other threads:[~2009-04-13 16:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 15:39 Alexander van Heukelum [this message]
2009-04-13 16:13 ` [PATCH] Fix warnings after: x86: apic - introduce imcr_ helpers Cyrill Gorcunov
2009-04-13 21:00 ` [tip:x86/apic] x86: fix function definitions " tip-bot for Alexander van Heukelum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413153924.GA20287@mailshack.com \
--to=heukelum@mailshack.com \
--cc=gorcunov@openvz.org \
--cc=heukelum@fastmail.fm \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox