public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
	Valdis.Kletnieks@vt.edu, Mike Travis <travis@sgi.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	mm-commits@vger.kernel.org, Rusty Russell <rusty@rustcorp.com.au>,
	Dave Jones <davej@redhat.com>, Len Brown <lenb@kernel.org>
Subject: Re: mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu
Date: Mon, 13 Apr 2009 19:41:04 +0200	[thread overview]
Message-ID: <20090413174104.GA856@elte.hu> (raw)
In-Reply-To: <20090413102749.4ca3a217.akpm@linux-foundation.org>


* Andrew Morton <akpm@linux-foundation.org> wrote:

> > I think Andrew has a stack of fixes queued up, one of which 
> > should solve this problem too - which Mike tested - as the 
> > commit from Andrew has caused another regression as well.
> > 
> > There's no sha1 - the patch is in this thread on lkml:
> > 
> >   sysbench(oltp)+mysql 10% regression with 2.6.30-rc1
> > 
> > | From: Andrew Morton <akpm@linux-foundation.org>
> > |
> > | Atttempting to rid us of the problematic work_on_cpu().  Just use
> > | smp_call_fuction_single() here.
> > |
> > | This repairs a 10% sysbench(oltp)+mysql regression which Mike 
> > | reported,
> > 
> 
> Yup.  It's presently in Len's hands.  And Rusty's.
> 
> Vladis, perhaps you can verify?

I have not tested it but it looks good and the use of a much more 
atomic primitive can only improve the situation - so unless there's 
something suspicious about it i'd suggest for Linus to pick this up 
from email, before -rc2.

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2009-04-13 17:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904100922.n3A9MOIV013828@imap1.linux-foundation.org>
2009-04-10 19:53 ` mmotm 2009-04-10-02-21 uploaded (shmem) Randy Dunlap
2009-04-10 20:00   ` Andrew Morton
2009-04-10 20:04     ` Randy Dunlap
2009-04-10 20:16     ` Hugh Dickins
2009-04-11 13:22 ` mmotm 2009-04-10-02-21 uploaded - forkbombed by work_for_cpu Valdis.Kletnieks
2009-04-13 16:04   ` Linus Torvalds
2009-04-13 16:34     ` Mike Galbraith
2009-04-13 17:18     ` Ingo Molnar
2009-04-13 17:27       ` Andrew Morton
2009-04-13 17:41         ` Ingo Molnar [this message]
2009-04-13 17:45         ` Linus Torvalds
2009-04-13 18:11           ` Ingo Molnar
2009-04-13 18:49           ` Andrew Morton
2009-04-13 19:03             ` Jeremy Fitzhardinge
2009-04-13 19:03             ` Dave Jones
2009-04-13 19:40               ` Ingo Molnar
2009-04-13 19:27         ` Valdis.Kletnieks
2009-04-13 23:50         ` Linus Torvalds
2009-04-14  0:31           ` Andrew Morton
2009-04-15  8:15         ` Ali Gholami Rudi
2009-04-15  8:34           ` Andrew Morton
2009-04-15  9:08             ` Ali Gholami Rudi
2009-04-15 14:45             ` Linus Torvalds
2009-04-14 12:42     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090413174104.GA856@elte.hu \
    --to=mingo@elte.hu \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=davej@redhat.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=rusty@rustcorp.com.au \
    --cc=torvalds@linux-foundation.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox