From: Ingo Molnar <mingo@elte.hu>
To: "Theodore Tso" <tytso@mit.edu>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Linux Kernel Developers List" <linux-kernel@vger.kernel.org>,
"Tom Zanussi" <tzanussi@gmail.com>,
"Li Zefan" <lizf@cn.fujitsu.com>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH, RFC 0/3] Improvements to the tracing documentation
Date: Tue, 14 Apr 2009 01:47:41 +0200 [thread overview]
Message-ID: <20090413234741.GI817@elte.hu> (raw)
In-Reply-To: <20090413233953.GA955@mit.edu>
* Theodore Tso <tytso@mit.edu> wrote:
> On Tue, Apr 14, 2009 at 12:55:42AM +0200, Ingo Molnar wrote:
> >
> > It could be worked around right now by converting it to an
> > integer but i think what we want is native support for kdev_t,
> > together with all the usual convenience forms of specifying it:
> > sda1 should work the same way as 8:1 or 0801. Even /dev/sda1
> > should be recognized in a filter expression.
>
> Yeah, I could just drop in the integer now, and and just have
> TP_printk() display "(8, 2)" instead of "sda2". It's really a
> question of how far we want to take pretty-printing and parsing
> for ftrace, I suppose.
We try to do it as far as daily use in /debug/tracing/ dictates.
Interacting with the kernel on such a direct channel is really
intuitive and useful in debugging and development sessions IMHO.
Raw binary records would encode it in an efficient and
well-specified manner, so information density is not hurt by
pretty-printing.
> But if we are going to have end-users use it, having real
> pretty-printed names would be a good thing, IMHO. Especially if
> major/minor numbers start becoming completely random beasts, as
> some have proposed. (I think it's a terrible idea, but I'm
> clearly not politically correct. :-)
Sounds like a terrible idea to me too. If more space is needed then
perhaps dynamically allocate the _new_ bits needed - but leave the
well-established spaces alone. Making everything random looking is
just asking for all sorts of trouble IMO. Making the system harder
to understand at a glance, on such a fundamental level, seems silly.
Ingo
next prev parent reply other threads:[~2009-04-13 23:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-11 19:51 [PATCH, RFC 0/3] Improvements to the tracing documentation Theodore Ts'o
2009-04-11 19:51 ` [PATCH, RFC 1/3] tracing: Update documentation references in kernel/trace/Kconfig Theodore Ts'o
2009-04-11 19:51 ` [PATCH, RFC 2/3] tracing: Document the event tracing system Theodore Ts'o
2009-04-11 19:51 ` [PATCH, RFC 3/3] tracing: Add documentation for the power tracer Theodore Ts'o
2009-04-11 20:44 ` Joe Perches
2009-04-11 21:48 ` Arjan van de Ven
2009-04-12 9:28 ` [tip:tracing/core] " Theodore Ts'o
2009-04-12 13:00 ` Theodore Ts'o
2009-04-12 9:27 ` [tip:tracing/core] tracing: Document the event tracing system Theodore Ts'o
2009-04-12 9:40 ` Cyrill Gorcunov
2009-04-12 13:00 ` Theodore Ts'o
2009-04-12 9:25 ` [PATCH, RFC 0/3] Improvements to the tracing documentation Ingo Molnar
2009-04-12 12:15 ` Theodore Tso
2009-04-12 13:01 ` Ingo Molnar
2009-04-12 17:23 ` Theodore Tso
2009-04-12 17:32 ` [PATCH 1/2] jbd2: Convert instrumentation from markers to tracepoints Theodore Ts'o
2009-04-12 17:32 ` [PATCH 2/2] ext4: " Theodore Ts'o
2009-04-13 21:37 ` Ingo Molnar
2009-04-13 21:31 ` [PATCH, RFC 0/3] Improvements to the tracing documentation Ingo Molnar
2009-04-13 22:35 ` Theodore Tso
2009-04-13 22:55 ` Ingo Molnar
2009-04-13 23:39 ` Theodore Tso
2009-04-13 23:47 ` Ingo Molnar [this message]
2009-04-14 5:22 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090413234741.GI817@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
--cc=tytso@mit.edu \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox