Re: linux-next: origin tree build failure

Ingo Molnar
2009-06-12T09:56:19Z

* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:

> On Fri, 2009-06-12 at 19:33 +1000, Benjamin Herrenschmidt wrote:
> > We should at least -try- to follow the
> > process we've defined, don't you think ?
>
> So you're saying -next should include whole new subsystems even
> though its not clear they will be merged?
>
> That'll invariably create the opposite case where a tree doesn't
> get pulled and breaks bits due to its absence.
>
> -next does a great job of sorting the existing subsystem trees,
> but I don't think its Stephens job to decide if things will get
> merged.
>
> Therefore when things are in limbo (there was no definite ACK from
> Linus on perf counters) both inclusion and exclusion from -next
> can lead to trouble.

Precisely. linux-next is for the uncontroversial stuff from existing
subsystems. Sometimes for features pushed by or approved by existing
subsystem maintainers. But it is not for controversial stuff - Linus
is the upstream maintainer, not Stephen.

We had a real mess with perfmon3 which was included into linux-next
in a rouge way without Cc:-ing the affected maintainers and against
the maintainers. There was a repeat incident recently as well, where
a tree was included into linux-next without the approval (and
without the Cc:) of affected maintainers. linux-next needs to be
more careful about adding trees.

All in one, we did the same with perfcounters that we expected of
perfmonv3. No double standard.

Nor is there any real issue here. The bug was my fault, it was
trivial to fix, it affects a small subset of testers and it is
already upstream, applied on the same day perfcounters were pulled.

Ingo