* [PATCH] ext2: fix missing mutex_unlock in error path
@ 2009-04-14 7:36 Akinobu Mita
2009-04-14 7:43 ` Manish Katiyar
2009-04-14 7:43 ` Jan Kara
0 siblings, 2 replies; 5+ messages in thread
From: Akinobu Mita @ 2009-04-14 7:36 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, linux-kernel
Add missing mutex_unlock in error path in ext2_quota_write()
Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
diff --git a/fs/ext2/super.c b/fs/ext2/super.c
index f983225..5c4afe6 100644
--- a/fs/ext2/super.c
+++ b/fs/ext2/super.c
@@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
blk++;
}
out:
- if (len == towrite)
+ if (len == towrite) {
+ mutex_unlock(&inode->i_mutex);
return err;
+ }
if (inode->i_size < off+len-towrite)
i_size_write(inode, off+len-towrite);
inode->i_version++;
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] ext2: fix missing mutex_unlock in error path
2009-04-14 7:36 [PATCH] ext2: fix missing mutex_unlock in error path Akinobu Mita
@ 2009-04-14 7:43 ` Manish Katiyar
2009-04-14 7:43 ` Jan Kara
1 sibling, 0 replies; 5+ messages in thread
From: Manish Katiyar @ 2009-04-14 7:43 UTC (permalink / raw)
To: Akinobu Mita; +Cc: Jan Kara, linux-ext4, linux-kernel
On Tue, Apr 14, 2009 at 1:06 PM, Akinobu Mita <akinobu.mita@gmail.com> wrote:
> Add missing mutex_unlock in error path in ext2_quota_write()
This has already been taken I think.
http://patchwork.ozlabs.org/patch/25661/
Thanks -
Manish
>
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index f983225..5c4afe6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
> blk++;
> }
> out:
> - if (len == towrite)
> + if (len == towrite) {
> + mutex_unlock(&inode->i_mutex);
> return err;
> + }
> if (inode->i_size < off+len-towrite)
> i_size_write(inode, off+len-towrite);
> inode->i_version++;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
Thanks -
Manish
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ext2: fix missing mutex_unlock in error path
2009-04-14 7:36 [PATCH] ext2: fix missing mutex_unlock in error path Akinobu Mita
2009-04-14 7:43 ` Manish Katiyar
@ 2009-04-14 7:43 ` Jan Kara
2009-04-14 9:35 ` Akinobu Mita
1 sibling, 1 reply; 5+ messages in thread
From: Jan Kara @ 2009-04-14 7:43 UTC (permalink / raw)
To: Akinobu Mita; +Cc: linux-ext4, linux-kernel
Hello,
On Tue 14-04-09 16:36:31, Akinobu Mita wrote:
> Add missing mutex_unlock in error path in ext2_quota_write()
>
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> ---
> diff --git a/fs/ext2/super.c b/fs/ext2/super.c
> index f983225..5c4afe6 100644
> --- a/fs/ext2/super.c
> +++ b/fs/ext2/super.c
> @@ -1395,8 +1395,10 @@ static ssize_t ext2_quota_write(struct super_block *sb, int type,
> blk++;
> }
> out:
> - if (len == towrite)
> + if (len == towrite) {
> + mutex_unlock(&inode->i_mutex);
> return err;
> + }
> if (inode->i_size < off+len-towrite)
> i_size_write(inode, off+len-towrite);
> inode->i_version++;
Thanks for the patch but I already have this patch in my quota tree from
Dan Carpenter...
Honza
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] ext2: fix missing mutex_unlock in error path
2009-04-14 7:43 ` Jan Kara
@ 2009-04-14 9:35 ` Akinobu Mita
2009-04-14 9:43 ` Akinobu Mita
0 siblings, 1 reply; 5+ messages in thread
From: Akinobu Mita @ 2009-04-14 9:35 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, linux-kernel
On Tue, Apr 14, 2009 at 09:43:57AM +0200, Jan Kara wrote:
> Thanks for the patch but I already have this patch in my quota tree from
> Dan Carpenter...
Oh, I should have checked your tree.
BTW, JFS still have same problem in jfs_quota_write()
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ext2: fix missing mutex_unlock in error path
2009-04-14 9:35 ` Akinobu Mita
@ 2009-04-14 9:43 ` Akinobu Mita
0 siblings, 0 replies; 5+ messages in thread
From: Akinobu Mita @ 2009-04-14 9:43 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-ext4, linux-kernel
On Tue, Apr 14, 2009 at 06:35:45PM +0900, Akinobu Mita wrote:
> On Tue, Apr 14, 2009 at 09:43:57AM +0200, Jan Kara wrote:
> > Thanks for the patch but I already have this patch in my quota tree from
> > Dan Carpenter...
>
> Oh, I should have checked your tree.
> BTW, JFS still have same problem in jfs_quota_write()
It's already fixed in JFS tree...
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2009-04-14 9:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-14 7:36 [PATCH] ext2: fix missing mutex_unlock in error path Akinobu Mita
2009-04-14 7:43 ` Manish Katiyar
2009-04-14 7:43 ` Jan Kara
2009-04-14 9:35 ` Akinobu Mita
2009-04-14 9:43 ` Akinobu Mita
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox