Re: [PATCH 00/14] convert voyager over to the x86 quirks model

[Ingo Molnar <mingo@elte.hu>]

* Ingo Molnar <mingo@elte.hu> wrote:

> 
> * James Bottomley <James.Bottomley@HansenPartnership.com> wrote:
> 
> >  39 files changed, 554 insertions(+), 726 deletions(-)
> 
> That diffstat is not against current mainline, is it? 
> Would you mind to send a proper diffstat with the revert 
> included as well? That will give us a complete picture.

ok, i did the calculations, and the effect of adding back 
x86/Voyager is roughly:

   48 files changed, 5226 insertions(+), 142 deletions(-)

That's quite a lot, and lets put this into perspective.

You are talking about moving ~5000 lines of legacy code back into 
arch/x86/, for a total of *four* Voyager/Linux systems, which are 
using _ancient_ 486/P5 era CPUs.

Two of these systems are in your house, two are somewhere unknown: 
their owners certainly never sent bugreports against recent mainline 
kernels (Voyager didnt even _build_ for a couple of straight kernel 
releases), and i suspect those boxes are probably decommissioned 
already.

A single core on my run-of-the-mill x86 laptop has more computing 
power than all Voyager/Linux systems on the planet, combined. And 
you now want to add back support to the mainline arch/x86 code, 
which we are trying hard to keep running on millions of x86 Linux 
systems?

You still have not given proper justification for doing that ...

Sorry to be the one to say 'no', but the reasons you gave so far 
were not very convincing to me.
 
Anyway, you seem to be willing to maintain this code it out of tree. 
If someone owns such an ancient Voyager box and wants to test a new 
kernel then your tree is a good starting point for doing that. 
There's really no pressing need to have this in mainline.

	Ingo