Re: [BUILD FAILURE 11/12] Next April 14 : PPC64 randconfig [drivers/spi/mpc52xx_psc_spi.c]

Grant Likely
2009-04-14T23:04:22Z

Damn. I didn't "reply to all" earlier in the thread. Adding back the
mailing list.

On Tue, Apr 14, 2009 at 4:27 PM, Anton Vorontsov
<avorontsov@ru.mvista.com> wrote:
> On Tue, Apr 14, 2009 at 04:19:56PM -0600, Grant Likely wrote:
>> On Tue, Apr 14, 2009 at 4:02 PM, Anton Vorontsov
>> <avorontsov@ru.mvista.com> wrote:
>> > On Tue, Apr 14, 2009 at 03:54:16PM -0600, Grant Likely wrote:
>> >> On Tue, Apr 14, 2009 at 3:51 PM, Anton Vorontsov
>> >> <avorontsov@ru.mvista.com> wrote:
>> >> > On Tue, Apr 14, 2009 at 03:31:39PM -0600, Grant Likely wrote:
>> >> >> On Tue, Apr 14, 2009 at 3:27 PM, Anton Vorontsov
>> >> >> <avorontsov@ru.mvista.com> wrote:
>> >> >> > On Tue, Apr 14, 2009 at 12:42:47PM -0600, Grant Likely wrote:
>> >> >> >> Thanks Subrata.  I'll look into this.
>> >> >> >
>> >> >> > Whoops. That's my fault, I didn't expect that anyone other
>> >> >> > than spi_mpc83xx is using fsl_spi_platform_data. :-/
>> >> >>
>> >> >> /me hands Anton a paper bag.
>> >> >
>> >> > Yeah... :-(
>> >> >
>> >> > This should fix the issue:
>> >>
>> >> Are there any users of this in tree?
>> >
>> > Nope. Sure, we should switch the driver to the gpios = <>,
>> > but I believe it's too late for 2.6.30, and FWIW, I can't test
>> > the result on the hardware (don't have any MPC52xx machines).
>> >
>> > So there are two options:
>> >
>> > 1. Remove the cs stuff completely (then the driver would only
>> >   handle SPI devices w/o chipselects, and thus we should state it
>> >   in the Kconfig).
>> > 2. Just fix the build (could also help non-mainline users, if any).
>>
>> Either way will break out of tree users.  I don't want to be forced
>> into such a decision during the stablization period.  The removal of
>> struct fsl_spi_platform_data needs to be reverted.
>
> Hm. struct fsl_spi_platform_data is still there. It's just there
> is no two functions (activate_cs and deactivate_cs) any longer,
> there's just one: cs_ontrol that takes "spi_device" and "on"
> arguments).
>
> And the build fix (down below) is trivial.

Regardless of how trivial the build fix is for in-tree, I'm not
thrilled with breaking out of tree users. I don't bend over backwards
for out-of-tree, but the decision should be intentional and not forced
into, especially during the stabilization period. Please add the
hooks back for 2.6.30. You can send another patch targeted at 2.6.31
-next to remove them again so that it can be discussed properly on the
list.

g.

>
>> g.
>>
>> >
>> >>
>> >> >
>> >> > ---
>> >> >
>> >> > diff --git a/drivers/spi/mpc52xx_psc_spi.c b/drivers/spi/mpc52xx_psc_spi.c
>> >> > index 68c77a9..e1901fd 100644
>> >> > --- a/drivers/spi/mpc52xx_psc_spi.c
>> >> > +++ b/drivers/spi/mpc52xx_psc_spi.c
>> >> > @@ -13,6 +13,7 @@
>> >> >
>> >> >  #include <linux/module.h>
>> >> >  #include <linux/init.h>
>> >> > +#include <linux/types.h>
>> >> >  #include <linux/errno.h>
>> >> >  #include <linux/interrupt.h>
>> >> >  #include <linux/of_platform.h>
>> >> > @@ -30,8 +31,7 @@
>> >> >
>> >> >  struct mpc52xx_psc_spi {
>> >> >        /* fsl_spi_platform data */
>> >> > -       void (*activate_cs)(u8, u8);
>> >> > -       void (*deactivate_cs)(u8, u8);
>> >> > +       void (*cs_control)(struct spi_device *spi, bool on);
>> >> >        u32 sysclk;
>> >> >
>> >> >        /* driver internal data */
>> >> > @@ -111,18 +111,16 @@ static void mpc52xx_psc_spi_activate_cs(struct spi_device *spi)
>> >> >        out_be16((u16 __iomem *)&psc->ccr, ccr);
>> >> >        mps->bits_per_word = cs->bits_per_word;
>> >> >
>> >> > -       if (mps->activate_cs)
>> >> > -               mps->activate_cs(spi->chip_select,
>> >> > -                               (spi->mode & SPI_CS_HIGH) ? 1 : 0);
>> >> > +       if (mps->cs_control)
>> >> > +               mps->cs_control(spi, (spi->mode & SPI_CS_HIGH) ? 1 : 0);
>> >> >  }
>> >> >
>> >> >  static void mpc52xx_psc_spi_deactivate_cs(struct spi_device *spi)
>> >> >  {
>> >> >        struct mpc52xx_psc_spi *mps = spi_master_get_devdata(spi->master);
>> >> >
>> >> > -       if (mps->deactivate_cs)
>> >> > -               mps->deactivate_cs(spi->chip_select,
>> >> > -                               (spi->mode & SPI_CS_HIGH) ? 1 : 0);
>> >> > +       if (mps->cs_control)
>> >> > +               mps->cs_control(spi, (spi->mode & SPI_CS_HIGH) ? 0 : 1);
>> >> >  }
>> >> >
>> >> >  #define MPC52xx_PSC_BUFSIZE (MPC52xx_PSC_RFNUM_MASK + 1)
>> >> > @@ -388,15 +386,13 @@ static int __init mpc52xx_psc_spi_do_probe(struct device *dev, u32 regaddr,
>> >> >        mps->irq = irq;
>> >> >        if (pdata == NULL) {
>> >> >                dev_warn(dev, "probe called without platform data, no "
>> >> > -                               "(de)activate_cs function will be called\n");
>> >> > -               mps->activate_cs = NULL;
>> >> > -               mps->deactivate_cs = NULL;
>> >> > +                               "cs_control function will be called\n");
>> >> > +               mps->cs_control = NULL;
>> >> >                mps->sysclk = 0;
>> >> >                master->bus_num = bus_num;
>> >> >                master->num_chipselect = 255;
>> >> >        } else {
>> >> > -               mps->activate_cs = pdata->activate_cs;
>> >> > -               mps->deactivate_cs = pdata->deactivate_cs;
>> >> > +               mps->cs_control = pdata->cs_control;
>> >> >                mps->sysclk = pdata->sysclk;
>> >> >                master->bus_num = pdata->bus_num;
>> >> >                master->num_chipselect = pdata->max_chipselect;
>> >> >
>> >>
>> >>
>> >>
>> >> --
>> >> Grant Likely, B.Sc., P.Eng.
>> >> Secret Lab Technologies Ltd.
>> >
>> > --
>> > Anton Vorontsov
>> > email: cbouatmailru@gmail.com
>> > irc://irc.freenode.net/bd2
>> >
>>
>>
>>
>> --
>> Grant Likely, B.Sc., P.Eng.
>> Secret Lab Technologies Ltd.
>
> --
> Anton Vorontsov
> email: cbouatmailru@gmail.com
> irc://irc.freenode.net/bd2
>

--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.