public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.arm.linux.org.uk,
	Bill Gatliff <bgat@billgatliff.com>
Subject: re: Linux 2.6.30-rc2: [PATCH] ARM OABI compatibility: fix build error
Date: Wed, 15 Apr 2009 10:33:26 +0200	[thread overview]
Message-ID: <20090415083326.GA12921@traven> (raw)
In-Reply-To: <alpine.LFD.2.00.0904141628570.4132@localhost.localdomain>

Building for ARM with CONFIG_OABI_COMPAT enabled fails due to a
missing include:

arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_epoll_wait':
arch/arm/kernel/sys_oabi-compat.c:288: error: implicit declaration of
function 'kmalloc'
arch/arm/kernel/sys_oabi-compat.c:288: error: 'GFP_KERNEL' undeclared
(first use in this function)
arch/arm/kernel/sys_oabi-compat.c:288: error: (Each undeclared
identifier is reported only once
arch/arm/kernel/sys_oabi-compat.c:288: error: for each function it
appears in.)
arch/arm/kernel/sys_oabi-compat.c:288: warning: assignment makes
pointer from integer without a cast
arch/arm/kernel/sys_oabi-compat.c:301: error: implicit declaration of
function 'kfree'
arch/arm/kernel/sys_oabi-compat.c: In function 'sys_oabi_semtimedop':
arch/arm/kernel/sys_oabi-compat.c:324: error: 'GFP_KERNEL' undeclared
(first use in this function)
arch/arm/kernel/sys_oabi-compat.c:324: warning: assignment makes
pointer from integer without a cast
make[1]: *** [arch/arm/kernel/sys_oabi-compat.o] Error 1
make: *** [arch/arm/kernel] Error 2

including linux/mm.h fixes this (thanks to Bill Gatliff for the pointer)

--

ARM: Fix build error when CONFIG_OABI_COMPAT is selected

Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>

---
 arch/arm/kernel/sys_oabi-compat.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/kernel/sys_oabi-compat.c b/arch/arm/kernel/sys_oabi-compat.c
index 42623db..5d666ac 100644
--- a/arch/arm/kernel/sys_oabi-compat.c
+++ b/arch/arm/kernel/sys_oabi-compat.c
@@ -80,6 +80,7 @@
 #include <linux/eventpoll.h>
 #include <linux/sem.h>
 #include <linux/socket.h>
+#include <linux/mm.h>
 #include <linux/net.h>
 #include <linux/ipc.h>
 #include <linux/uaccess.h>
-- 
1.6.2.1


  parent reply	other threads:[~2009-04-15  8:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-14 23:48 Linux 2.6.30-rc2 Linus Torvalds
2009-04-15  0:22 ` Alessandro Suardi
2009-04-15  1:17   ` Linus Torvalds
2009-04-15  0:40 ` patch-2.6.30-rc2.bz2 does not apply cleanly Tetsuo Handa
2009-04-15  1:42 ` Linux 2.6.30-rc2 Zhang, Yanmin
2009-04-15  2:01   ` Linus Torvalds
2009-04-15  2:24     ` Tetsuo Handa
2009-04-15 13:26     ` Alessandro Suardi
2009-04-15  6:21 ` Brice Goglin
2009-04-15  7:33   ` yakui_zhao
2009-04-15  7:41     ` Zhang Rui
2009-04-15  7:43       ` Brice Goglin
2009-04-15  8:33 ` Matthias Kaehlcke [this message]
2009-04-15  9:03   ` Linux 2.6.30-rc2: [PATCH] ARM OABI compatibility: fix build error Russell King - ARM Linux
2009-04-15  9:12     ` Matthias Kaehlcke
2009-04-15  9:29       ` Russell King - ARM Linux
2009-04-15  9:35         ` Matthias Kaehlcke
2009-04-15 12:22 ` Linux 2.6.30-rc2 Eyal Lebedinsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090415083326.GA12921@traven \
    --to=matthias@kaehlcke.net \
    --cc=bgat@billgatliff.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox