* [PATCH] regulator: remove extraneous semicolon
@ 2009-04-15 8:52 Eugene Teo
2009-04-15 9:51 ` Mark Brown
0 siblings, 1 reply; 3+ messages in thread
From: Eugene Teo @ 2009-04-15 8:52 UTC (permalink / raw)
To: Liam Girdwood; +Cc: linux-kernel, eugeneteo
An extraneous ";" after the if statement is a bad idea.
Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
---
drivers/regulator/core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 01f7702..47fc6e6 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -540,8 +540,8 @@ static void drms_uA_update(struct regulator_dev *rdev)
err = regulator_check_drms(rdev);
if (err < 0 || !rdev->desc->ops->get_optimum_mode ||
- !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode);
- return;
+ !rdev->desc->ops->get_voltage || !rdev->desc->ops->set_mode)
+ return;
/* get output voltage */
output_uV = rdev->desc->ops->get_voltage(rdev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: remove extraneous semicolon
2009-04-15 8:52 [PATCH] regulator: remove extraneous semicolon Eugene Teo
@ 2009-04-15 9:51 ` Mark Brown
2009-04-15 15:58 ` Liam Girdwood
0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2009-04-15 9:51 UTC (permalink / raw)
To: Eugene Teo; +Cc: Liam Girdwood, linux-kernel
On Wed, Apr 15, 2009 at 04:52:22PM +0800, Eugene Teo wrote:
> An extraneous ";" after the if statement is a bad idea.
>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
Someone sent the same patch a couple of days ago so that one might end
up getting merged instead but in any case
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] regulator: remove extraneous semicolon
2009-04-15 9:51 ` Mark Brown
@ 2009-04-15 15:58 ` Liam Girdwood
0 siblings, 0 replies; 3+ messages in thread
From: Liam Girdwood @ 2009-04-15 15:58 UTC (permalink / raw)
To: Eugene Teo; +Cc: Mark Brown, linux-kernel, linux-kernel
On Wed, 2009-04-15 at 10:51 +0100, Mark Brown wrote:
> On Wed, Apr 15, 2009 at 04:52:22PM +0800, Eugene Teo wrote:
> > An extraneous ";" after the if statement is a bad idea.
> >
> > Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
>
> Someone sent the same patch a couple of days ago so that one might end
> up getting merged instead but in any case
>
Thanks, I've just applied the earlier patch as it was first in my inbox.
Liam
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-15 15:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-15 8:52 [PATCH] regulator: remove extraneous semicolon Eugene Teo
2009-04-15 9:51 ` Mark Brown
2009-04-15 15:58 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox