public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eugene Teo <eugeneteo@kernel.sg>
To: Yan Zheng <zheng.yan@oracle.com>
Cc: linux-kernel@vger.kernel.org, eugeneteo@kernel.sg
Subject: [PATCH] Btrfs: setting variable out of order
Date: Wed, 15 Apr 2009 17:11:26 +0800	[thread overview]
Message-ID: <20090415091126.GA13323@kernel.sg> (raw)

This doesn't look intentional.

Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
---
 fs/btrfs/ctree.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index e5b2533..6aa2468 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
btrfs_trans_handle *trans,
        for (i = 0; i < nr; i++) {
                if (total_size + data_size[i] + sizeof(struct btrfs_item) >
                    BTRFS_LEAF_DATA_SIZE(root)) {
-                       break;
                        nr = i;
+                       break;
               	}
                total_data += data_size[i];
                total_size += data_size[i] + sizeof(struct btrfs_item);

             reply	other threads:[~2009-04-15  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-15  9:11 Eugene Teo [this message]
2009-04-15 12:59 ` [PATCH] Btrfs: setting variable out of order Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090415091126.GA13323@kernel.sg \
    --to=eugeneteo@kernel.sg \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zheng.yan@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox