* [PATCH] Btrfs: setting variable out of order
@ 2009-04-15 9:11 Eugene Teo
2009-04-15 12:59 ` Chris Mason
0 siblings, 1 reply; 2+ messages in thread
From: Eugene Teo @ 2009-04-15 9:11 UTC (permalink / raw)
To: Yan Zheng; +Cc: linux-kernel, eugeneteo
This doesn't look intentional.
Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
---
fs/btrfs/ctree.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
index e5b2533..6aa2468 100644
--- a/fs/btrfs/ctree.c
+++ b/fs/btrfs/ctree.c
@@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
btrfs_trans_handle *trans,
for (i = 0; i < nr; i++) {
if (total_size + data_size[i] + sizeof(struct btrfs_item) >
BTRFS_LEAF_DATA_SIZE(root)) {
- break;
nr = i;
+ break;
}
total_data += data_size[i];
total_size += data_size[i] + sizeof(struct btrfs_item);
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] Btrfs: setting variable out of order
2009-04-15 9:11 [PATCH] Btrfs: setting variable out of order Eugene Teo
@ 2009-04-15 12:59 ` Chris Mason
0 siblings, 0 replies; 2+ messages in thread
From: Chris Mason @ 2009-04-15 12:59 UTC (permalink / raw)
To: Eugene Teo; +Cc: Yan Zheng, linux-kernel
On Wed, 2009-04-15 at 17:11 +0800, Eugene Teo wrote:
> This doesn't look intentional.
>
> Signed-off-by: Eugene Teo <eugeneteo@kernel.sg>
> ---
> fs/btrfs/ctree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c
> index e5b2533..6aa2468 100644
> --- a/fs/btrfs/ctree.c
> +++ b/fs/btrfs/ctree.c
> @@ -3376,8 +3376,8 @@ int btrfs_insert_some_items(struct
> btrfs_trans_handle *trans,
> for (i = 0; i < nr; i++) {
> if (total_size + data_size[i] + sizeof(struct btrfs_item) >
> BTRFS_LEAF_DATA_SIZE(root)) {
> - break;
> nr = i;
> + break;
> }
Thanks,
This function isn't used anymore, I'll drop it.
-chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-15 12:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-15 9:11 [PATCH] Btrfs: setting variable out of order Eugene Teo
2009-04-15 12:59 ` Chris Mason
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox