Re: [PATCH] netfilter: use per-CPU r**ursive lock {XV}

Stephen Hemminger
2009-04-27T19:07:29Z

On Mon, 27 Apr 2009 20:54:23 +0200
Ingo Molnar <mingo@elte.hu> wrote:

>
> * Stephen Hemminger <shemminger@vyatta.com> wrote:
>
> > > non of the linux kernel locking primitives have this -- with the
> > > possible exception of the cpu-hotplug lock.
> > >
> > > What rwlock_t has, is reader bias to the point where you can
> > > utterly starve writers, with the side effect that you can obtain
> > > multiple read ownerships without causing a deadlock.
> >
> > But what happens when this side effect disappears?
>
> Then well written code works, badly written code breaks.
>
> > > [...]
> > >
> > > This is all common and well understood terminology, not
> > > something Linus invented just to harras you with.
> >
> > In Documentation/ ? online ? Where is the definition? The only
> > reference I se is indirectly in DocBook/kernel-locking.tmpl.
>
> Sure, see:
>
> http://tinyurl.com/c6fakc

All those references support my argument that the lock is being
used recursively in this case. It is being acquired multiple
times by the same CPU. This is not new, it has always been
acquired multiple times, so my change does not break anything.

If other implementations of reader locks to not nest the same
way, then on those system iptables can deadlock. Nothing was
changed by this.

> > > Generally speaking we do not condone recursive locking
> > > strategies -- and afaik reiserfs (as per the BKL) and the
> > > network code (as per abusing rwlock_t unfairness) are the only
> > > offenders.
> > >
> > > Like Linus stated, recursive locking is generally poor taste and
> > > indicates you basically gave up on trying to find a proper
> > > locking scheme. We should very much work towards getting rid of
> > > these abberations instead of adding new ones.
> >
> > The people complaining about naming never seem to be the ones
> > providing workable suggestions or patches.
>
> The thing is, while you now have named your locking primitive
> correctly, you are still abusing it by using it recursively.
>
> So it's not 'just about naming'. You should not use read-locks as
> recursive locks. It's poor code.

If you don't like the proposal please, think of a better alternative.
Not just pseudo code that is broken with handwaving arguments.