* [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
@ 2009-04-12 12:23 Zhenwen Xu
2009-04-15 21:32 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Zhenwen Xu @ 2009-04-12 12:23 UTC (permalink / raw)
To: sean.hefty; +Cc: hal.rosenstock, general, linux-kernel
Fix this warning:
drivers/infiniband/hw/nes/nes_cm.c:862: warning: unused variable ‘tmp_addr’
the 'tmp_addr' is defined for debug, so it should be defined in
CONFIG_INFINIBAND_NES_DEBUG
>From 5f67884bcda5450807dcd080378d829628e4db1c Mon Sep 17 00:00:00 2001
From: Zhenwen Xu <Helight.Xu@gmail.com>
Date: Sun, 12 Apr 2009 20:12:18 +0800
Subject: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
Signed-off-by: Zhenwen Xu <helight.xu@gmail.com>
---
drivers/infiniband/hw/nes/nes_cm.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
index dbd9a75..1bad93b 100644
--- a/drivers/infiniband/hw/nes/nes_cm.c
+++ b/drivers/infiniband/hw/nes/nes_cm.c
@@ -854,8 +854,9 @@ static struct nes_cm_listener *find_listener(struct nes_cm_core *cm_core,
{
unsigned long flags;
struct nes_cm_listener *listen_node;
+#ifdef CONFIG_INFINIBAND_NES_DEBUG
__be32 tmp_addr = cpu_to_be32(dst_addr);
-
+#endif
/* walk list and find cm_node associated with this session ID */
spin_lock_irqsave(&cm_core->listen_list_lock, flags);
list_for_each_entry(listen_node, &cm_core->listen_list.list, list) {
--
1.5.6.5
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
2009-04-12 12:23 [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862: Zhenwen Xu
@ 2009-04-15 21:32 ` Andrew Morton
2009-04-16 1:11 ` Zhenwen Xu
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2009-04-15 21:32 UTC (permalink / raw)
To: Zhenwen Xu; +Cc: sean.hefty, hal.rosenstock, general, linux-kernel
On Sun, 12 Apr 2009 20:23:17 +0800
Zhenwen Xu <helight.xu@gmail.com> wrote:
> Fix this warning:
> drivers/infiniband/hw/nes/nes_cm.c:862: warning: unused variable ___tmp_addr___
>
> the 'tmp_addr' is defined for debug, so it should be defined in
> CONFIG_INFINIBAND_NES_DEBUG
>
>
> >From 5f67884bcda5450807dcd080378d829628e4db1c Mon Sep 17 00:00:00 2001
> From: Zhenwen Xu <Helight.Xu@gmail.com>
> Date: Sun, 12 Apr 2009 20:12:18 +0800
> Subject: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
>
> Signed-off-by: Zhenwen Xu <helight.xu@gmail.com>
> ---
> drivers/infiniband/hw/nes/nes_cm.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
> index dbd9a75..1bad93b 100644
> --- a/drivers/infiniband/hw/nes/nes_cm.c
> +++ b/drivers/infiniband/hw/nes/nes_cm.c
> @@ -854,8 +854,9 @@ static struct nes_cm_listener *find_listener(struct nes_cm_core *cm_core,
> {
> unsigned long flags;
> struct nes_cm_listener *listen_node;
> +#ifdef CONFIG_INFINIBAND_NES_DEBUG
> __be32 tmp_addr = cpu_to_be32(dst_addr);
> -
> +#endif
> /* walk list and find cm_node associated with this session ID */
> spin_lock_irqsave(&cm_core->listen_list_lock, flags);
> list_for_each_entry(listen_node, &cm_core->listen_list.list, list) {
eek, an ugly ifdef. And we can't just remove tmp_addr because
printk(%p) wants to be passed an address rather than a value.
It'd be nice if we had a handy macro to squish the warning, like
uninitialized_var.
As it happens, uninitialized_var() _does_ suppress the unused-var warning:
--- a/drivers/infiniband/hw/nes/nes_cm.c~drivers-infiniband-hw-nes-nes_cmc-fix-unused-var-warning-cleanup
+++ a/drivers/infiniband/hw/nes/nes_cm.c
@@ -854,9 +854,8 @@ static struct nes_cm_listener *find_list
{
unsigned long flags;
struct nes_cm_listener *listen_node;
-#ifdef CONFIG_INFINIBAND_NES_DEBUG
- __be32 tmp_addr = cpu_to_be32(dst_addr);
-#endif
+ __be32 uninitialized_var(tmp_addr) = cpu_to_be32(dst_addr);
+
/* walk list and find cm_node associated with this session ID */
spin_lock_irqsave(&cm_core->listen_list_lock, flags);
list_for_each_entry(listen_node, &cm_core->listen_list.list, list) {
but that seems a bit abusive ;)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
2009-04-15 21:32 ` Andrew Morton
@ 2009-04-16 1:11 ` Zhenwen Xu
0 siblings, 0 replies; 3+ messages in thread
From: Zhenwen Xu @ 2009-04-16 1:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: sean.hefty, hal.rosenstock, general, linux-kernel
On Wed, Apr 15, 2009 at 02:32:28PM -0700, Andrew Morton wrote:
> On Sun, 12 Apr 2009 20:23:17 +0800
> Zhenwen Xu <helight.xu@gmail.com> wrote:
>
> > Fix this warning:
> > drivers/infiniband/hw/nes/nes_cm.c:862: warning: unused variable ___tmp_addr___
> >
> > the 'tmp_addr' is defined for debug, so it should be defined in
> > CONFIG_INFINIBAND_NES_DEBUG
> >
> >
> > >From 5f67884bcda5450807dcd080378d829628e4db1c Mon Sep 17 00:00:00 2001
> > From: Zhenwen Xu <Helight.Xu@gmail.com>
> > Date: Sun, 12 Apr 2009 20:12:18 +0800
> > Subject: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862:
> >
> > Signed-off-by: Zhenwen Xu <helight.xu@gmail.com>
> > ---
> > drivers/infiniband/hw/nes/nes_cm.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c
> > index dbd9a75..1bad93b 100644
> > --- a/drivers/infiniband/hw/nes/nes_cm.c
> > +++ b/drivers/infiniband/hw/nes/nes_cm.c
> > @@ -854,8 +854,9 @@ static struct nes_cm_listener *find_listener(struct nes_cm_core *cm_core,
> > {
> > unsigned long flags;
> > struct nes_cm_listener *listen_node;
> > +#ifdef CONFIG_INFINIBAND_NES_DEBUG
> > __be32 tmp_addr = cpu_to_be32(dst_addr);
> > -
> > +#endif
> > /* walk list and find cm_node associated with this session ID */
> > spin_lock_irqsave(&cm_core->listen_list_lock, flags);
> > list_for_each_entry(listen_node, &cm_core->listen_list.list, list) {
>
> eek, an ugly ifdef. And we can't just remove tmp_addr because
> printk(%p) wants to be passed an address rather than a value.
>
> It'd be nice if we had a handy macro to squish the warning, like
> uninitialized_var.
>
> As it happens, uninitialized_var() _does_ suppress the unused-var warning:
>
> --- a/drivers/infiniband/hw/nes/nes_cm.c~drivers-infiniband-hw-nes-nes_cmc-fix-unused-var-warning-cleanup
> +++ a/drivers/infiniband/hw/nes/nes_cm.c
> @@ -854,9 +854,8 @@ static struct nes_cm_listener *find_list
> {
> unsigned long flags;
> struct nes_cm_listener *listen_node;
> -#ifdef CONFIG_INFINIBAND_NES_DEBUG
> - __be32 tmp_addr = cpu_to_be32(dst_addr);
> -#endif
> + __be32 uninitialized_var(tmp_addr) = cpu_to_be32(dst_addr);
> +
> /* walk list and find cm_node associated with this session ID */
> spin_lock_irqsave(&cm_core->listen_list_lock, flags);
> list_for_each_entry(listen_node, &cm_core->listen_list.list, list) {
>
>
> but that seems a bit abusive ;)
Thanks! I got.
--
---------------------------------
Zhenwen Xu - Open and Free
Home Page: http://zhwen.org
My Studio: http://dim4.cn
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-16 1:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-04-12 12:23 [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862: Zhenwen Xu
2009-04-15 21:32 ` Andrew Morton
2009-04-16 1:11 ` Zhenwen Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox