From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753736AbZDPBMp (ORCPT ); Wed, 15 Apr 2009 21:12:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751029AbZDPBMf (ORCPT ); Wed, 15 Apr 2009 21:12:35 -0400 Received: from ti-out-0910.google.com ([209.85.142.184]:52932 "EHLO ti-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752553AbZDPBMe (ORCPT ); Wed, 15 Apr 2009 21:12:34 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:reply-to:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=sdZ534VclROhHP9IlDYTmiUuhYHSvanb3GZhy9Z8wKaEeSga/Whc5462m+cAmlrpKU oadyPWXHokBHhXlzEY+ldVn0sUMk6s5IdH25esAUosjnntsSbWBKQ7KBecZjnKdjf77o +zcP5usCV/9A60GowuCOTB92qvV2RqPEfgeOY= Date: Thu, 16 Apr 2009 09:11:02 +0800 From: Zhenwen Xu To: Andrew Morton Cc: sean.hefty@intel.com, hal.rosenstock@gmail.com, general@lists.openfabrics.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862: Message-ID: <20090416011102.GA3419@helight> Reply-To: Zhenwen Xu References: <20090412122317.GA4787@helight> <20090415143228.d57a0201.akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090415143228.d57a0201.akpm@linux-foundation.org> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2009 at 02:32:28PM -0700, Andrew Morton wrote: > On Sun, 12 Apr 2009 20:23:17 +0800 > Zhenwen Xu wrote: > > > Fix this warning: > > drivers/infiniband/hw/nes/nes_cm.c:862: warning: unused variable ___tmp_addr___ > > > > the 'tmp_addr' is defined for debug, so it should be defined in > > CONFIG_INFINIBAND_NES_DEBUG > > > > > > >From 5f67884bcda5450807dcd080378d829628e4db1c Mon Sep 17 00:00:00 2001 > > From: Zhenwen Xu > > Date: Sun, 12 Apr 2009 20:12:18 +0800 > > Subject: [PATCH] fix a warning on drivers/infiniband/hw/nes/nes_cm.c:862: > > > > Signed-off-by: Zhenwen Xu > > --- > > drivers/infiniband/hw/nes/nes_cm.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c > > index dbd9a75..1bad93b 100644 > > --- a/drivers/infiniband/hw/nes/nes_cm.c > > +++ b/drivers/infiniband/hw/nes/nes_cm.c > > @@ -854,8 +854,9 @@ static struct nes_cm_listener *find_listener(struct nes_cm_core *cm_core, > > { > > unsigned long flags; > > struct nes_cm_listener *listen_node; > > +#ifdef CONFIG_INFINIBAND_NES_DEBUG > > __be32 tmp_addr = cpu_to_be32(dst_addr); > > - > > +#endif > > /* walk list and find cm_node associated with this session ID */ > > spin_lock_irqsave(&cm_core->listen_list_lock, flags); > > list_for_each_entry(listen_node, &cm_core->listen_list.list, list) { > > eek, an ugly ifdef. And we can't just remove tmp_addr because > printk(%p) wants to be passed an address rather than a value. > > It'd be nice if we had a handy macro to squish the warning, like > uninitialized_var. > > As it happens, uninitialized_var() _does_ suppress the unused-var warning: > > --- a/drivers/infiniband/hw/nes/nes_cm.c~drivers-infiniband-hw-nes-nes_cmc-fix-unused-var-warning-cleanup > +++ a/drivers/infiniband/hw/nes/nes_cm.c > @@ -854,9 +854,8 @@ static struct nes_cm_listener *find_list > { > unsigned long flags; > struct nes_cm_listener *listen_node; > -#ifdef CONFIG_INFINIBAND_NES_DEBUG > - __be32 tmp_addr = cpu_to_be32(dst_addr); > -#endif > + __be32 uninitialized_var(tmp_addr) = cpu_to_be32(dst_addr); > + > /* walk list and find cm_node associated with this session ID */ > spin_lock_irqsave(&cm_core->listen_list_lock, flags); > list_for_each_entry(listen_node, &cm_core->listen_list.list, list) { > > > but that seems a bit abusive ;) Thanks! I got. -- --------------------------------- Zhenwen Xu - Open and Free Home Page: http://zhwen.org My Studio: http://dim4.cn