Re: Fix quilt merge error in acpi-cpufreq.c

Ingo Molnar
2009-04-16T07:44:59Z

* Theodore Tso <tytso@mit.edu> wrote:

> On Thu, Apr 16, 2009 at 03:46:42AM +0200, Ingo Molnar wrote:
> >
> > For similar reasons people have memos, stick-it's and other formal,
> > automated, reflex-alike daily routine measures to make sure they
> > dont forget to do something they all too easily forget otherwise.
> ...
> > This kind of formal measure _forces_ the extraction of this very
> > specific type of summary on all sides of the contribution chain -
> > and it drastically reduced the number of commits i regretted in
> > hindsight.
>
> The question is whether Impact: _works_ in its current form. [...]

For us, it clearly works in most cases. Does it work in _every_
case? No. No maintenance measure ever works in every case.

> [...] I was came across a recent set of commits sent to you where
> it was pathetically obvious that Impact: doesn't really help.

The thing is - none of the examples you quoted below are commits in
any of our trees! They are email submissions to lkml, not applied
yet anywhere. And yes, from the impact line alone it becomes clear
that the commit log needs serious editing.

And yes, in fact it became _easier_ to me to process patches from
that particular patch submitter you blacked out, since he started
using impact-lines a few months ago. These bad impact lines you
quoted are of course not usable directly in a commit log - but they
are canaries. Plus the ones where i for example get "Impact:
cleanup" patches from him are certainly useful.

So even this worst-case example you could possibly can come up with
is in reality actually a success story to us!

Impact tags allow frequent contributors to pre-tag changes with a
"this I expected to be an easy one" easily recognizable attribute.
It is very helpful, _especially_ where there's a language barrier.

Here's an easy challenge: try inserting perfect impact lines for a
few days into all your commits, really! :-) [ You can erase them
after you've created them, and you dont have to admit it ever that
you did this experiment ;-) ]

I noticed that even the best commits win a new dimension of quality
and awareness as far as the maintainer is concerned. It also helps
us keep our eyes on the ball all the time: constantly assessing the
true utility and true risk of our patches.

It's truly useful, and unless you try it seriously and come back to
us with a "I tried it, all my impact lines were perfect but it didnt
give me any plus so i stopped doing it" i dont think you can ever
know what you missed out on.

Ingo