Re: Fix quilt merge error in acpi-cpufreq.c

Ingo Molnar
2009-04-15T23:05:18Z

* Andrew Morton <akpm@linux-foundation.org> wrote:

> On Wed, 15 Apr 2009 23:03:53 +0200
> Ingo Molnar <mingo@elte.hu> wrote:
>
> > what can we do?
>
> Write better patch titles?

Lets start with a patch title that you wrote:

| commit 6b44003e5ca66a3fffeb5bc90f40ada2c4340896
| Author: Andrew Morton <akpm@linux-foundation.org>
| Date: Thu Apr 9 09:50:37 2009 -0600
|
| work_on_cpu(): rewrite it to create a kernel thread on demand
|
| Impact: circular locking bugfix

... and to which Rusty added an impact line.

Where is the impact in that title you wrote? How could it have been
written differently to include the impact? Why didnt you give it a
better title? How can you expect us to do a better title if you
yourself dont do titles with impact information?

If the impact cannot be included, can it be included elsewhere in
the commit perhaps? If it can be included elsewhere in the commit,
is it allowed to be summarized in a structured way, or must it stay
mixed into a free-flowing text description?

Ingo