Re: Fix quilt merge error in acpi-cpufreq.c

Linus Torvalds
2009-04-16T01:08:25Z

On Thu, 16 Apr 2009, Ingo Molnar wrote:
>
> So would a:
>
> The impact of this change: it is a pure cleanup.
>
> Formalization be acceptable? We tried to make it short and fit into
> a single line - but we can certainly make it longer.

Language is not a "fit to one string" thing.

It doesn't matter what the string is: if you haev a fixed format, it's not
human language. It's that easy.

Don't make up stupid fixed-format rules, and most certainly don't make
them make the real payload harder to tread.

If people write "The impact of this is to fix compilation", then that's
fine as an occasional thing, although it's damned stilted English, and I
certainly wouldn't ever recommend it. Why not just say

This fixes a compile problem in file so-and-so.

instead? Much clearer to everybody.

> You just dont seem to understand why i find it useful. You also seem
> to try to deprive us the basic right of creating new, field-specific
> language variants we find useful in our everyday work. And that
> sucks.

YOU HAVE NEVER GIVEN A COHERENT REASON FOR FINDING IT USEFUL!

Yes, you bring up the same reason every time: namely that you want to know
what the patch does. But never _once_ have you given a reason fo why that
fixed-format string helps at all.

That's what i've been trying to tell you: don't use stilted and artificial
fixed formats where it doesn't make sense.

Instead of

Impact: cleanup

just write

Cleanup xyz by doing abc

which is MORE informational, and much easier for everybody to read.

That's all I'm asking. Stop making the commit messages harder to read,
uglier, and less informative.

[ And if it's purely for "grep", then you can damn well hide it at the end
where nobody sane cares any more, but you seem to not have been able to
acknowledge that if it's for 'grep', then you're _missing_ all the
changes that don't have that string in the first place, so that's not a
very good reason _either_. ]

Linus