Re: Fix quilt merge error in acpi-cpufreq.c

H. Peter Anvin
2009-04-15T17:03:30Z

Impact: fix meaning reversal

H. Peter Anvin wrote:
>
> I generally find I spend about three times longer reviewing the same
> amount of code from someone who has written Impact: lines on their
> patches, mostly because it means they have thought about it. It does
> get reflected in the rest of the patch. Also, if they aren't there, I
> do end up writing them, and quite often find issues in the process.
>

That should, of course, have been who has *not* written Impact: lines... ;)

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.