Re: Fix quilt merge error in acpi-cpufreq.c

Valdis.Kletnieks
2009-04-16T15:27:24Z

[-- Attachment #1: Type: text/plain, Size: 682 bytes --]

On Thu, 16 Apr 2009 02:50:25 +0200, Ingo Molnar said:

> Something like:

Avoid the passive voice when feasible.

> The impact of this change is that the build is fixed.

Fix the build breakage caused by bad #include screwage.

> The impact of this change is that the code gets cleaner.

Neaten up the spaghetti code.

> The impact of this change is that the CPU does not overheat.

Prevent the CPU from overheating.

Good clear concise writing doesn't need an 'Impact:' to draw attention to it.

About the *only* use case that I've seen that actually makes *any* sense is
the *one* case where adding "fix on s390 and x86" to the original Subject:
line caused it to be overlong.

[-- Attachment #2: Type: application/pgp-signature, Size: 226 bytes --]