From: Ingo Molnar <mingo@elte.hu>
To: Thomas Renninger <trenn@suse.de>
Cc: djwong@us.ibm.com, linux-kernel <linux-kernel@vger.kernel.org>,
cpufreq@vger.kernel.org, linux-acpi@vger.kernel.org
Subject: Re: [PATCH v2] acpi: Fix regression where _PPC is not read at boot even when ignore_ppc=0
Date: Thu, 16 Apr 2009 12:32:58 +0200 [thread overview]
Message-ID: <20090416103258.GR9813@elte.hu> (raw)
In-Reply-To: <200904161201.13409.trenn@suse.de>
* Thomas Renninger <trenn@suse.de> wrote:
> The *reevaluate* implies that the _PPC value has been
> evaluated/initialized by the OS already and Ingo's patch would be
> wrong then. I'd like to have a look at the T60's ACPI parts and
> find out what exactly (or if at all) makes _PPC to return sane
> values, I expect it's _PDC.
>
> Hmm, I could also imagine that Ingo's T60 patch is not needed
> anymore since Yakui's patch
> (0ac3c571315a53c14d2733564f14ebdb911fe903). This one could make
> sure that _PDC is evaluated first making the internal ACPI _PPC
> state initialize and makes sure _PPC gets only called afterwards.
>
> If this patch does not break Ingo's T60, I think this should go
> in. Due to Yakui's reordering/cleanup of ACPI function calls, I
> think also the notifier chain I introduced is not needed anymore
> and I can clean this up if I find some time.
Feel free to do so, if it's expected to work. I'll let you know if
it breaks the T60 box - i still have it in the -tip test mix.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2009-04-16 10:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 22:53 [PATCH] acpi: Fix regression where _PPC is not read at boot even when ignore_ppc=0 Darrick J. Wong
2009-04-16 0:27 ` [PATCH v2] " Darrick J. Wong
2009-04-16 10:01 ` Thomas Renninger
2009-04-16 10:32 ` Ingo Molnar [this message]
2009-04-16 17:42 ` Darrick J. Wong
2009-04-16 18:49 ` Thomas Renninger
2009-04-16 22:45 ` Matthew Garrett
2009-04-20 5:13 ` Len Brown
2009-04-20 9:13 ` Thomas Renninger
2009-04-20 10:45 ` Ingo Molnar
2009-04-29 13:19 ` Thomas Renninger
2009-04-29 14:48 ` Ingo Molnar
2009-04-29 21:43 ` Darrick J. Wong
2009-04-30 9:07 ` Thomas Renninger
2009-04-30 9:17 ` Ingo Molnar
2009-04-20 22:18 ` Henrique de Moraes Holschuh
2009-04-28 19:33 ` Darrick J. Wong
2009-04-28 19:53 ` Matthew Garrett
2009-04-28 20:24 ` Darrick J. Wong
2009-04-29 21:39 ` Darrick J. Wong
2009-04-29 22:00 ` Matthew Garrett
2009-04-30 7:25 ` Ingo Molnar
2009-04-30 9:54 ` Matthew Garrett
2009-04-30 11:10 ` Ingo Molnar
2009-04-30 11:13 ` Matthew Garrett
2009-05-15 19:12 ` Darrick J. Wong
2009-06-02 23:21 ` Darrick J. Wong
2009-06-07 10:05 ` Ingo Molnar
2009-07-15 0:32 ` Darrick J. Wong
2010-02-16 22:07 ` Matthew Garrett
2010-02-16 22:26 ` Darrick J. Wong
2010-02-18 9:02 ` Len Brown
2010-02-18 18:28 ` Darrick J. Wong
2010-02-19 6:12 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416103258.GR9813@elte.hu \
--to=mingo@elte.hu \
--cc=cpufreq@vger.kernel.org \
--cc=djwong@us.ibm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).