Re: [PATCH] tracing/filters: allow on-the-fly filter switching

[Frederic Weisbecker <fweisbec@gmail.com>]

On Thu, Apr 16, 2009 at 08:54:13AM +0800, Li Zefan wrote:
> Frederic Weisbecker wrote:
> >>> Also, is filter_add_pred() supposed to be available for in-kernel
> >>> uses by other tracers or something?
> >> No, the current callers were the only ones I'd planned on (it's not
> >> static because code in trace_events.c needs to call it).  But, do you
> >> see a use for it by other tracers?
> > 
> > 
> > 
> > May be in the future, it's possible that a tracer might want to
> > set filters by itself.
> > But I don't think it has to be fixed now because there are nothing
> > like that for now.
> > 
> > So, no problem :-)
> > 
> 
> If we restricted the mutex in trace_events_filters.c only, all the
> extern functions can be called without lock, and this is what I did
> in my previous patch.


Indeed, sounds better.

 
> >  
> >>> If this is planned, the locking could be even deeper than my comments.
>