From: Frederic Weisbecker <fweisbec@gmail.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Ingo Molnar <mingo@elte.hu>, Steven Rostedt <rostedt@goodmis.org>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC][PATCH 1/2] tracing/events: provide string with undefined size support
Date: Thu, 16 Apr 2009 18:19:21 +0200 [thread overview]
Message-ID: <20090416161920.GI6004@nowhere> (raw)
In-Reply-To: <49E6E439.1090607@cn.fujitsu.com>
On Thu, Apr 16, 2009 at 03:54:33PM +0800, Li Zefan wrote:
> >>> + entry = ring_buffer_event_data(event); \
> >> small nits, below is better since we have only one assignment:
> >>
> >> entry = ring_buffer_event_data(event);
> >
> >
> >
> > Hm, I don't understand what you are suggesting.
> >
>
> I meant just add a ' ' before '=' instead of a tab:
>
> entry = ring_buffer_event_data(event);
> entry = ring_buffer_event_data(event);
>
> since we don't need to align with other assignment statement.
>
> but this is just a trivial issue. :)
Ah ok :)
Will fix it (unless I remove this part to address Steven's comment.
Thanks.
> --
> Zefan
next prev parent reply other threads:[~2009-04-16 16:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 23:27 [RFC][PATCH 1/2] tracing/events: provide string with undefined size support Frederic Weisbecker
2009-04-15 23:27 ` [RFC][PATCH 2/2] tracing/lock: provide lock_acquired event support for dynamic size string Frederic Weisbecker
2009-04-16 1:13 ` [RFC][PATCH 1/2] tracing/events: provide string with undefined size support Li Zefan
2009-04-16 7:42 ` Frederic Weisbecker
2009-04-16 7:54 ` Li Zefan
2009-04-16 16:19 ` Frederic Weisbecker [this message]
2009-04-16 1:33 ` Steven Rostedt
2009-04-16 7:35 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090416161920.GI6004@nowhere \
--to=fweisbec@gmail.com \
--cc=a.p.zijlstra@chello.nl \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox