From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758220AbZDPTGT (ORCPT ); Thu, 16 Apr 2009 15:06:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756619AbZDPTGF (ORCPT ); Thu, 16 Apr 2009 15:06:05 -0400 Received: from mail.fieldses.org ([141.211.133.115]:59086 "EHLO pickle.fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756577AbZDPTGC (ORCPT ); Thu, 16 Apr 2009 15:06:02 -0400 Date: Thu, 16 Apr 2009 15:06:01 -0400 To: H Hartley Sweeten Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] net/sunrpc/svc.c: fix sparse warning Message-ID: <20090416190601.GA1145@fieldses.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) From: "J. Bruce Fields" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2009 at 03:46:13PM -0400, H Hartley Sweeten wrote: > Fix sparse warning in net/sunrpc/svc.c. > > warning: symbol 'node' shadows an earlier one What's the other symbol? > > Signed-off-by: H Hartley Sweeten > > --- > > diff --git a/net/sunrpc/svc.c b/net/sunrpc/svc.c > index 8847add..e781135 100644 > --- a/net/sunrpc/svc.c > +++ b/net/sunrpc/svc.c > @@ -122,7 +122,7 @@ module_param_call(pool_mode, param_set_pool_mode, > param_get_pool_mode, > static int > svc_pool_map_choose_mode(void) > { > - unsigned int node; > + unsigned int nid; > > if (num_online_nodes() > 1) { > /* > @@ -132,8 +132,8 @@ svc_pool_map_choose_mode(void) > return SVC_POOL_PERNODE; > } > > - node = any_online_node(node_online_map); > - if (nr_cpus_node(node) > 2) { > + nid = any_online_node(node_online_map); > + if (nr_cpus_node(nid) > 2) { > /* > * Non-trivial SMP, or CONFIG_NUMA on > * non-NUMA hardware, e.g. with a generic > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/