From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
Steven Rostedt <rostedt@goodmis.org>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [patch 2/3] RCU move trace defines to rcupdate_defines.h
Date: Thu, 16 Apr 2009 20:55:21 -0400 [thread overview]
Message-ID: <20090417005521.GA23828@Krystal> (raw)
In-Reply-To: <20090417004352.GA1988@elte.hu>
* Ingo Molnar (mingo@elte.hu) wrote:
>
> * mathieu.desnoyers@polymtl.ca <mathieu.desnoyers@polymtl.ca> wrote:
>
> > include/linux/rcupdate.h | 127 ------------------------------
> > include/linux/rcupdate_defines.h | 163 +++++++++++++++++++++++++++++++++++++++
>
> Looks good to me (if Paul accepts it too), but please use the
> standard convention we use in other places for 'light' headers:
> rcupdate_types.h.
>
> Ingo
Given there were not "types" declared per-se, I thought _defines was
more appropriate. But I don't mind, as long as we separate the heavy
from the "light" header. I'll repost with _types.h.
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2009-04-17 0:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 0:14 [patch 0/3] Tracepoints kill rcupdate header dependency mathieu.desnoyers
2009-04-17 0:14 ` [patch 1/3] rcupdate header remove whitespace mathieu.desnoyers
2009-04-17 0:14 ` [patch 2/3] RCU move trace defines to rcupdate_defines.h mathieu.desnoyers
2009-04-17 0:43 ` Ingo Molnar
2009-04-17 0:55 ` Mathieu Desnoyers [this message]
2009-04-17 1:04 ` Ingo Molnar
2009-04-17 0:14 ` [patch 3/3] tracepoints : remove rcupdate.h dependency mathieu.desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417005521.GA23828@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox