From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [patch 2/3] RCU move trace defines to rcupdate_types.h
Date: Thu, 16 Apr 2009 21:42:09 -0400 [thread overview]
Message-ID: <20090417014209.GA24956@Krystal> (raw)
In-Reply-To: <alpine.DEB.2.00.0904162122250.20429@gandalf.stny.rr.com>
* Steven Rostedt (rostedt@goodmis.org) wrote:
>
> On Thu, 16 Apr 2009, Jeremy Fitzhardinge wrote:
>
> > I don't think this helps. rcupdate_types.h uses preempt_disable/enable, but
> > doesn't include linux/preempt.h for them - but someone's going to have to, so
> > you've got an implicit dependency on the user to #include the right headers in
> > advance.
>
> Would including linux/preempt.h in rcupdate_types.h be a problem?
>
> -- Steve
>
I did not include preempt.h in rcupdate_types.h because rcupdate.h did
not include it, so I thought it had a special status such a kernel.h.
However, I notice the rcupdate.h includes spinlock.h, which in turn
includes preempt.h, so we would need to include preempt.h in
rcupdate_types.h.
But I think preempt.h is pretty much only type definitions. I don't
think that would be a problem, but maybe Jeremy knows better.
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2009-04-17 1:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 0:37 [patch 0/3] Tracepoints kill rcupdate header dependency (v2) mathieu.desnoyers
2009-04-17 0:37 ` [patch 1/3] rcupdate header remove whitespace mathieu.desnoyers
2009-04-17 0:37 ` [patch 2/3] RCU move trace defines to rcupdate_types.h mathieu.desnoyers
2009-04-17 1:10 ` Jeremy Fitzhardinge
2009-04-17 1:22 ` Steven Rostedt
2009-04-17 1:42 ` Mathieu Desnoyers [this message]
2009-04-17 1:47 ` Mathieu Desnoyers
2009-04-17 6:23 ` Jeremy Fitzhardinge
2009-04-17 5:57 ` Jeremy Fitzhardinge
2009-04-17 15:16 ` Mathieu Desnoyers
2009-04-17 15:26 ` Jeremy Fitzhardinge
2009-04-17 15:42 ` Mathieu Desnoyers
2009-04-17 16:14 ` Jeremy Fitzhardinge
2009-04-17 16:38 ` Steven Rostedt
2009-04-17 17:09 ` Jeremy Fitzhardinge
2009-04-17 2:38 ` [patch 2/3] RCU move trace defines to rcupdate_types.h (update) Mathieu Desnoyers
2009-04-17 0:37 ` [patch 3/3] tracepoints : remove rcupdate.h dependency mathieu.desnoyers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417014209.GA24956@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=akpm@linux-foundation.org \
--cc=hch@lst.de \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox