From: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
To: Christoph Hellwig <hch@infradead.org>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
Steven Rostedt <rostedt@goodmis.org>, Ingo Molnar <mingo@elte.hu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>
Subject: Re: [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE
Date: Fri, 17 Apr 2009 11:21:08 -0400 [thread overview]
Message-ID: <20090417152108.GC13842@Krystal> (raw)
In-Reply-To: <20090417064820.GA20685@infradead.org>
* Christoph Hellwig (hch@infradead.org) wrote:
> On Thu, Apr 16, 2009 at 11:35:38PM -0700, Jeremy Fitzhardinge wrote:
> > -DEFINE_TRACE(power_mark);
> > +DEFINE_TRACE(power_mark,
> > + TP_PROTO(struct power_trace *it, unsigned int type, unsigned int state),
> > + TP_ARGS(it, type, state));
>
> Wrong indentation, the TP_ARGS should have the same level of indentation
> (one) as the TP_PROTO. Also true for all others.
>
Ingo actually proposed to add a supplementary indentation before TP_ARGS
in trace/sched.h to ease readability.
Mathieu
--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68
next prev parent reply other threads:[~2009-04-17 15:26 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 6:35 [PATCH] tracing WIP patches Jeremy Fitzhardinge
2009-04-17 6:35 ` [PATCH 1/4] tracing: move __DO_TRACE out of line Jeremy Fitzhardinge
2009-04-17 15:46 ` Ingo Molnar
2009-04-17 16:10 ` Mathieu Desnoyers
2009-04-17 16:23 ` Ingo Molnar
2009-04-17 16:47 ` Jeremy Fitzhardinge
2009-04-17 19:31 ` Jeremy Fitzhardinge
2009-04-17 19:46 ` Ingo Molnar
2009-04-17 19:57 ` Steven Rostedt
2009-04-17 19:58 ` Jeremy Fitzhardinge
2009-04-17 20:06 ` Steven Rostedt
2009-04-18 6:53 ` Mathieu Desnoyers
2009-04-18 14:16 ` Steven Rostedt
2009-04-19 3:59 ` Mathieu Desnoyers
2009-04-19 23:38 ` Jeremy Fitzhardinge
2009-04-20 21:39 ` Mathieu Desnoyers
2009-04-19 23:40 ` Jeremy Fitzhardinge
2009-04-20 21:47 ` Mathieu Desnoyers
2009-04-17 6:35 ` [PATCH 2/4] x86/pvops: target CREATE_TRACE_POINTS to particular subsystems Jeremy Fitzhardinge
2009-04-17 15:55 ` Steven Rostedt
2009-04-17 16:14 ` Jeremy Fitzhardinge
2009-04-17 16:32 ` Steven Rostedt
2009-04-17 16:48 ` Jeremy Fitzhardinge
2009-04-17 16:57 ` Steven Rostedt
2009-04-17 17:14 ` Jeremy Fitzhardinge
2009-04-17 17:33 ` Steven Rostedt
2009-04-17 18:11 ` Jeremy Fitzhardinge
2009-04-17 6:35 ` [PATCH 3/4] tracing: pass proto and args to DEFINE_TRACE Jeremy Fitzhardinge
2009-04-17 6:48 ` Christoph Hellwig
2009-04-17 6:58 ` Jeremy Fitzhardinge
2009-04-17 7:05 ` Christoph Hellwig
2009-04-17 12:53 ` Ingo Molnar
2009-04-17 15:21 ` Mathieu Desnoyers [this message]
2009-04-17 6:35 ` [PATCH 4/4] tracing: avoid warnings from zero-arg tracepoints Jeremy Fitzhardinge
2009-04-17 15:53 ` Steven Rostedt
2009-04-17 15:53 ` Ingo Molnar
2009-04-17 16:10 ` [tip:tracing/core] " tip-bot for Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417152108.GC13842@Krystal \
--to=mathieu.desnoyers@polymtl.ca \
--cc=hch@infradead.org \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox