From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Cc: x86 maintainers <x86@kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git-pull -tip] x86: fix section mismatch warnings
Date: Fri, 17 Apr 2009 18:41:41 +0200 [thread overview]
Message-ID: <20090417164141.GJ8253@elte.hu> (raw)
In-Reply-To: <1239918902.10567.22.camel@ht.satnam>
* Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
> The following changes since commit 88dc4c8e38d64db32907e0bd605f8c1ec4c4d1bd:
> Ingo Molnar (1):
> Merge branch 'tracing/ftrace'
>
> are available in the git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master
>
> Jaswinder Singh Rajput (3):
> x86: mm/numa_32.c calculate_numa_remap_pages should use __init
> x86: apic/es7000_32.c find_unisys_acpi_oem_table and es7000_acpi_madt_oem_check should use __init
> x86: smpboot.c wakeup_secondary_cpu_via_nmi do not required __devinit
The commit logs lack analysis. The suggestions in the warnings are
advisory and can be wrong. Analysis explaining what happened, maybe
even when it happened, and what should be done about it to fix that
issue is needed in such changelogs.
The commits might be correct - or they might be bogus. The commit
logs dont give us any help in deciding that. I.e. if you did that
work, you should document it. If you _didnt_ do that analysis work,
you shouldnt send patches addressing these types of warnings.
Ingo
next prev parent reply other threads:[~2009-04-17 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 21:55 [git-pull -tip] x86: fix section mismatch warnings Jaswinder Singh Rajput
2009-04-17 16:41 ` Ingo Molnar [this message]
2009-04-17 18:01 ` Jaswinder Singh Rajput
2009-04-17 19:03 ` Ingo Molnar
2009-04-17 20:36 ` [tip:x86/urgent] x86: mm/numa_32.c calculate_numa_remap_pages should use __init tip-bot for Jaswinder Singh Rajput
2009-04-17 20:46 ` tip-bot for Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417164141.GJ8253@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox