public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>,
	Alessio Igor Bogani <abogani@texware.it>,
	Alexander Viro <viro@ftp.linux.org.uk>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH -tip] remove the BKL: Replace BKL in mount/umount syscalls with a mutex
Date: Fri, 17 Apr 2009 18:41:34 +0100	[thread overview]
Message-ID: <20090417174134.GK26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1239987885.23397.4817.camel@laptop>

On Fri, Apr 17, 2009 at 07:04:45PM +0200, Peter Zijlstra wrote:
> On Fri, 2009-04-17 at 18:56 +0200, Ingo Molnar wrote:
> 
> > Stupid question regarding c): wouldnt such data structures go via 
> > the VFS - which you said was free of BKL constraints? Or are there 
> > interconnected private data structures between certain types of 
> > closely related filesystems that the VFS does not know about? (and 
> > hence might have BKL assumptions)
> 
> The VFS is stuffed with ->private like pointers for filesystems to flesh
> out, and I could well imagine some implicit serialization between the
> various (4?) VFS hooks that are currently still under BKL.

Explicit one, TYVM...  Anyway, any fs that dares to use private data of
objects from another filesystem deserves everything it gets; I'm not
aware of any that would do that and I have no sympathy whatsoever to
any that would try.

That's not what I'd been talking about, though; what we want to watch out
for is sharing of data structures by some (or all) fs instances of given
type.  I.e. internals of particular fs driver, not cross-driver problems.

  parent reply	other threads:[~2009-04-17 17:41 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-16 14:27 [PATCH -tip] remove the BKL: Replace BKL in mount/umount syscalls with a mutex Alessio Igor Bogani
2009-04-16 14:36 ` Christoph Hellwig
2009-04-16 16:49   ` Ingo Molnar
2009-04-16 17:01     ` Christoph Hellwig
2009-04-16 17:13       ` Ingo Molnar
2009-04-17  0:05       ` Al Viro
2009-04-16 16:06 ` Ingo Molnar
2009-04-16 16:58   ` Ingo Molnar
2009-04-16 23:56   ` Al Viro
2009-04-17  0:01     ` Ingo Molnar
2009-04-17  0:13       ` Al Viro
2009-04-17  0:27         ` Ingo Molnar
2009-04-17  0:38           ` Al Viro
2009-04-17 16:56             ` Ingo Molnar
2009-04-17 17:04               ` Peter Zijlstra
2009-04-17 17:21                 ` Linus Torvalds
2009-04-17 17:31                   ` Jonathan Corbet
2009-04-17 18:03                     ` Linus Torvalds
2009-04-17 18:44                       ` Matthew Wilcox
2009-04-22 17:28                         ` J. Bruce Fields
2009-04-17 18:08                   ` Al Viro
2009-04-17 18:34                   ` Ingo Molnar
2009-04-17 17:41                 ` Al Viro [this message]
2009-04-17 17:34               ` Al Viro
2009-04-16 23:49 ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090417174134.GK26366@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=a.p.zijlstra@chello.nl \
    --cc=abogani@texware.it \
    --cc=corbet@lwn.net \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox