From: Frederic Weisbecker <fweisbec@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Ingo Molnar <mingo@elte.hu>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tracing/lockdep: turn lock->name into an array
Date: Fri, 17 Apr 2009 22:29:37 +0200 [thread overview]
Message-ID: <20090417202936.GB6331@nowhere> (raw)
In-Reply-To: <alpine.DEB.2.00.0904171336030.14919@gandalf.stny.rr.com>
On Fri, Apr 17, 2009 at 01:36:58PM -0400, Steven Rostedt wrote:
>
>
> On Fri, 17 Apr 2009, Peter Zijlstra wrote:
>
> > On Fri, 2009-04-17 at 10:25 -0700, Jeremy Fitzhardinge wrote:
> > > Ingo Molnar wrote:
> > > > We could zap all pending trace entries on module unload (it is a
> > > > rare operation)
> > >
> > > ....Unless you're trying to trace something across a module unload. I
> > > don't know if its at all practical, but it would be nice to just zap the
> > > pointers within the buffer, rather than the whole buffer.
> >
> > I think the new __string() thing that's in the works will avoid the
> > whole problem by copying the string into the buffer, instead of keeping
> > a reference.
>
> Speaking of which. We have not heard back from Frederic on this yet. I
> hope he's taking a break, enjoying the sun, and not stuck on some tricky
> macro crap ;-)
>
> -- Steve
>
Oh you haven't yet received my mail about that?
It said I was cheering up about your and Peter's idea of using offsets
instead of pointer because of the end result:
- We can use as much __string() as we want
- No need for something else, such as the strcpy bits
- We are not forced to put it in the end of the patch
- Which means I will implement that in a v3 very soon ;-)
Frederic.
prev parent reply other threads:[~2009-04-17 20:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-13 22:36 [PATCH] tracing/lockdep: turn lock->name into an array Frederic Weisbecker
2009-04-13 22:42 ` Frederic Weisbecker
2009-04-13 22:58 ` Ingo Molnar
2009-04-14 7:48 ` Peter Zijlstra
2009-04-14 10:27 ` Ingo Molnar
2009-04-14 21:22 ` Frederic Weisbecker
2009-04-13 23:01 ` Ingo Molnar
2009-04-14 0:24 ` Frederic Weisbecker
2009-04-14 6:35 ` KOSAKI Motohiro
2009-04-14 6:53 ` Ingo Molnar
2009-04-14 6:56 ` KOSAKI Motohiro
2009-04-14 7:20 ` Peter Zijlstra
2009-04-14 10:25 ` Ingo Molnar
2009-04-17 17:25 ` Jeremy Fitzhardinge
2009-04-17 17:27 ` Peter Zijlstra
2009-04-17 17:36 ` Steven Rostedt
2009-04-17 20:29 ` Frederic Weisbecker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090417202936.GB6331@nowhere \
--to=fweisbec@gmail.com \
--cc=jeremy@goop.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox