From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Frédéric Weisbecker" <fweisbec@gmail.com>
Subject: Re: [PATCH] tracing: remove format attribute of inline function
Date: Sat, 18 Apr 2009 09:14:26 +0200 [thread overview]
Message-ID: <20090418071426.GD7678@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0904171717080.1016@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
>
> Due to a cut and paste error, I added the gcc attribute for printf
> format to the static inline stub of trace_seq_printf.
>
> This will cause a compile failure.
>
> [ Impact: fix compiler error when CONFIG_TRACING is off ]
>
> Reported-by: Ingo Molnar <mingo@elte.hu>
> Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Applied, thanks Steve!
We also need to make CONFIG_TRACING an interactive option as well
which i suggested before, so that people can enable/disable this
stuff in a convenient summary way, even if they have KERNEL_DEBUG
enabled otherwise.
Thanks,
Ingo
next prev parent reply other threads:[~2009-04-18 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 21:17 [PATCH] tracing: remove format attribute of inline function Steven Rostedt
2009-04-18 7:14 ` Ingo Molnar [this message]
2009-04-18 16:28 ` [tip:tracing/core] " tip-bot for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090418071426.GD7678@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox