From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sam Ravnborg <sam@ravnborg.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
takata@linux-m32r.org, Christoph Hellwig <hch@lst.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: use include/gen for mach-types.h
Date: Sat, 18 Apr 2009 21:53:18 +0100 [thread overview]
Message-ID: <20090418205318.GT26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.2.00.0904181226170.4042@localhost.localdomain>
On Sat, Apr 18, 2009 at 12:28:51PM -0700, Linus Torvalds wrote:
>
>
> On Sat, 18 Apr 2009, Sam Ravnborg wrote:
> >
> > diff --git a/include/gen/.gitignore b/include/gen/.gitignore
> > new file mode 100644
> > index 0000000..1e809fd
> > --- /dev/null
> > +++ b/include/gen/.gitignore
> > @@ -0,0 +1,2 @@
> > +# mach-types.h is used by arm
> > +mach-types.h
>
> I think this is bad.
>
> The whole point of having 'include/gen' should be that _all_ files in that
> directory should be generated. So it should be include/.gitignore that
> just contains the pattern "gen/" and that's it.
Or .gitignore in top-level, same as for include/config
next prev parent reply other threads:[~2009-04-18 20:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 15:07 last remaining asm/ header moves: h8300 and m32r Christoph Hellwig
2009-04-16 16:40 ` Sam Ravnborg
2009-04-17 2:23 ` [GIT PULL] m32r: move include/asm-m32r to arch/m32r/include/asm takata
2009-04-17 17:37 ` Linus Torvalds
2009-04-17 22:14 ` Sam Ravnborg
2009-04-18 10:14 ` Russell King
2009-04-18 18:17 ` [PATCH] arm: use include/gen for mach-types.h Sam Ravnborg
2009-04-18 18:52 ` Al Viro
2009-04-18 19:28 ` Linus Torvalds
2009-04-18 19:55 ` [PATCH v2] " Sam Ravnborg
2009-04-18 20:53 ` Al Viro [this message]
2009-04-16 16:49 ` last remaining asm/ header moves: h8300 and m32r Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090418205318.GT26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=takata@linux-m32r.org \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox