From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760340AbZDSMet (ORCPT ); Sun, 19 Apr 2009 08:34:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756986AbZDSMej (ORCPT ); Sun, 19 Apr 2009 08:34:39 -0400 Received: from mail-ew0-f176.google.com ([209.85.219.176]:51715 "EHLO mail-ew0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757468AbZDSMeh (ORCPT ); Sun, 19 Apr 2009 08:34:37 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=DDWLIopwp9/DFj2NxVlwklu0xGqxrRS90Pv/7oLcaWxBS3MqvhOPoDbOx5S2qZ9FXo ETsvoZq1Rs0VpUF+klU5Y2YjZRHEkIALxqM1Jp4uc7IxrmO5esxEfPzLBcGyJjF14jnU /Zsf4l+NmeNXVM4UQtpM7TaTkHDyTy2fYYjU0= Date: Sun, 19 Apr 2009 14:34:32 +0200 From: Frederic Weisbecker To: Li Zefan Cc: Ingo Molnar , Steven Rostedt , Zhaolei , Tom Zanussi , KOSAKI Motohiro , LKML , Peter Zijlstra Subject: Re: [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Message-ID: <20090419123430.GA5967@nowhere> References: <1240117295-6873-1-git-send-email-fweisbec@gmail.com> <49EAC15E.7080702@cn.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49EAC15E.7080702@cn.fujitsu.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 19, 2009 at 02:14:54PM +0800, Li Zefan wrote: > Frederic Weisbecker wrote: > > Hi, > > > > Here is the v3 of the __string() field patchset. > > It applies suggestions from Steven and Peter with some arrangements. > > > > This time, filtering is not supported (though it is ready in a pending patch). > > I wanted to provide it but it looks like filtering has been broken recently. > > Once I set a usual string filter, no more traces appear, and clearing it > > doesn't change anything. > > > > I tried it, and triggered a WARNING, and ring buffers was > disabled permanently: I've also seen this warning but on another event. I don't think this is related to this patchset but more about the tracing recursion detection. For exemple, here we are in an Irq event, which doesn't use the __string() thing. For such off-case, the only change is a variable declaration and a + 0 operation. Another thing: I've only seen it in a selftest. I will investigate. Thanks. Frederic. > > ------------[ cut here ]------------ > WARNING: at kernel/trace/ring_buffer.c:1501 ring_buffer_lock_reserve+0x78/0x122() > Hardware name: Aspire SA85 > Modules linked in: autofs4 parport_pc parport button sg r8169 mii sata_sis pata_sis ata_generic libata sd_mod scsi_mod ext3 jbd mbcache uhci_hcd ohci_hcd ehci_hcd [last unloaded: scsi_wait_scan] > Pid: 0, comm: swapper Not tainted 2.6.30-rc2-tip #84 > Call Trace: > [] warn_slowpath+0x79/0x8f > [] ? __rcu_read_unlock+0x70/0x7f > [] ? trace_hardirqs_off+0xb/0xd > [] ? __rcu_read_unlock+0x70/0x7f > [] ? trace_hardirqs_off+0xb/0xd > [] ? __rcu_read_unlock+0x70/0x7f > [] ? _spin_unlock_irqrestore+0x34/0x5d > [] ? trace_hardirqs_off_caller+0x8f/0xaf > [] ring_buffer_lock_reserve+0x78/0x122 > [] trace_buffer_lock_reserve+0x11/0x34 > [] trace_current_buffer_lock_reserve+0x19/0x1e > [] ftrace_raw_event_irq_handler_exit+0x34/0x73 > [] handle_IRQ_event+0xcc/0x169 > [] handle_fasteoi_irq+0x77/0xb0 > [] ? handle_fasteoi_irq+0x0/0xb0 > [] ? do_IRQ+0x4e/0xa3 > [] ? common_interrupt+0x2e/0x34 > [] ? lockdep_init_map+0x2d5/0x39f > [] ? mwait_idle+0xab/0x100 > [] ? cpu_idle+0x53/0x85 > [] ? start_secondary+0x1aa/0x1b1 > ---[ end trace ab1a6955379aeb3f ]--- > >