From: Al Viro <viro@ZenIV.linux.org.uk>
To: Zhenwen Xu <helight.xu@gmail.com>
Cc: linux-kernel@vger.kernel.org, eparis@redhat.com, linux-audit@redhat.com
Subject: Re: [PATCH] this mutex_lock is miss used
Date: Sun, 19 Apr 2009 16:32:28 +0100 [thread overview]
Message-ID: <20090419153228.GU26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090419140355.GA16609@helight>
On Sun, Apr 19, 2009 at 10:03:55PM +0800, Zhenwen Xu wrote:
>
> This mutex_lock and mutex_unlock has no use in such way.
Incorrect. They delay sending response until we are out of audit_receive().
> It should be like this way:
No, it should not. In particular, it should *NOT* be held while sending
these packets.
prev parent reply other threads:[~2009-04-19 15:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 14:03 [PATCH] this mutex_lock is miss used Zhenwen Xu
2009-04-19 15:32 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090419153228.GU26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=eparis@redhat.com \
--cc=helight.xu@gmail.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox