Re: [PATCH] cs553x: fix build dependency problems

[Andres Salomon <dilinger@queued.net>]

On Sat, 18 Apr 2009 18:01:18 -0700
Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Andres, how does this look to you?
> 
> It fixes the problems that I know about.
> 
> 
> 

This may be okay as a separate patch, but doesn't really fix the problem.
cs553x-gpio isn't just for OLPC, it can be used by plain Geodes.  I've
lost track of the state of the patches at this point, but the solution
would be to simply have CONFIG_GPIO_CS553X depend upon PCI.




> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix multiple build errors due to cs553x-gpio using GPIO APIs
> and using PCI APIs.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> ---
>  arch/x86/Kconfig |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> --- mmotm-2009-0417-1519.orig/arch/x86/Kconfig
> +++ mmotm-2009-0417-1519/arch/x86/Kconfig
> @@ -1969,7 +1969,8 @@ config GEODE_MFGPT_TIMER
>  
>  config OLPC
>  	bool "One Laptop Per Child support"
> -	select GPIO_CS553X
> +	select GPIO_CS553X if PCI
> +	select GPIOLIB if PCI
>  	default n
>  	---help---
>  	  Add support for detecting the unique features of the OLPC