From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Paul Mundt <lethal@linux-sh.org>,
linux-kbuild <linux-kbuild@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
jdike@addtoit.com
Subject: Re: [GIT] kbuild
Date: Mon, 20 Apr 2009 06:15:38 +0100 [thread overview]
Message-ID: <20090420051538.GX26366@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20090420044551.GB8494@uranus.ravnborg.org>
On Mon, Apr 20, 2009 at 06:45:51AM +0200, Sam Ravnborg wrote:
> For kernel proper the use of -idirafter would be confusing.
> But for um alone we should be safe provided it is properly commented.
Less than for all um - it's only for USER_OBJ there. It is special,
simply because for uml the counterpart of really low-level glue has
to talk to libc. So there we have separation into "normal kernel source"
and "userland code that uses userland headers, calls libc functions, etc."
> I have already fixed um the obvious way for asm-offsets in my local tree.
> But if you prefer I can add a -dirafter based patch before the "move
> asm-offsets.h to incldue/generated" patch.
I've dumped several header cleanup patches for uml into
git://git.kernel.org/pub/scm/linux/kernel/git/viro/um-header.git/
including the -idirafter, move of user_constants.h, etc.
Another fun thing: user.h used to be included directly by just about
every userland-side file. Switched it to -include user.h (for USER_CFLAGS,
of course - not for normal stuff), killed includes, got rid of shitloads
of kern_constants.h includes at the same time. At which point getting
rid of kern_constants.h became trivial.
Up to Jeff's approval, obviously - *including* -idirafter patch.
next prev parent reply other threads:[~2009-04-20 5:16 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 9:25 [GIT] kbuild Sam Ravnborg
2009-04-19 22:39 ` Paul Mundt
2009-04-19 23:45 ` Sam Ravnborg
2009-04-20 0:52 ` Linus Torvalds
2009-04-20 1:41 ` Al Viro
2009-04-20 2:49 ` Al Viro
2009-04-20 4:45 ` Sam Ravnborg
2009-04-20 5:15 ` Al Viro [this message]
2009-04-20 8:24 ` Sam Ravnborg
2009-04-20 4:42 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2010-07-07 9:08 Michal Marek
2010-07-07 16:41 ` Linus Torvalds
2010-07-08 5:47 ` Michal Marek
2010-03-08 14:34 Michal Marek
2009-09-21 17:56 Sam Ravnborg
2009-06-14 21:09 Sam Ravnborg
2009-05-01 10:15 Sam Ravnborg
2009-04-11 19:45 Sam Ravnborg
2009-03-18 19:35 Sam Ravnborg
2009-03-11 19:24 Sam Ravnborg
2009-02-17 21:11 Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420051538.GX26366@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jdike@addtoit.com \
--cc=lethal@linux-sh.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox