From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S1754241AbZDTFQL@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754241AbZDTFQL (ORCPT <rfc822;w@1wt.eu>);
	Mon, 20 Apr 2009 01:16:11 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753736AbZDTFPo
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Mon, 20 Apr 2009 01:15:44 -0400
Received: from zeniv.linux.org.uk ([195.92.253.2]:44538 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753307AbZDTFPn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 20 Apr 2009 01:15:43 -0400
Date: Mon, 20 Apr 2009 06:15:38 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
       Paul Mundt <lethal@linux-sh.org>,
       linux-kbuild <linux-kbuild@vger.kernel.org>,
       LKML <linux-kernel@vger.kernel.org>,
       Andrew Morton <akpm@linux-foundation.org>,
       Russell King <rmk+lkml@arm.linux.org.uk>,
       Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
       Thomas Gleixner <tglx@linutronix.de>, jdike@addtoit.com
Subject: Re: [GIT] kbuild
Message-ID: <20090420051538.GX26366@ZenIV.linux.org.uk>
References: <20090419092555.GA19213@uranus.ravnborg.org> <20090419223959.GB12054@linux-sh.org> <20090419234501.GA6475@uranus.ravnborg.org> <alpine.LFD.2.00.0904191745390.2199@localhost.localdomain> <20090420014158.GV26366@ZenIV.linux.org.uk> <20090420024954.GW26366@ZenIV.linux.org.uk> <20090420044551.GB8494@uranus.ravnborg.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20090420044551.GB8494@uranus.ravnborg.org>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Apr 20, 2009 at 06:45:51AM +0200, Sam Ravnborg wrote:

> For kernel proper the use of -idirafter would be confusing.
> But for um alone we should be safe provided it is properly commented.

Less than for all um - it's only for USER_OBJ there.  It is special,
simply because for uml the counterpart of really low-level glue has
to talk to libc.  So there we have separation into "normal kernel source"
and "userland code that uses userland headers, calls libc functions, etc."
 
> I have already fixed um the obvious way for asm-offsets in my local tree.
> But if you prefer I can add a -dirafter based patch before the "move
> asm-offsets.h to incldue/generated" patch.

I've dumped several header cleanup patches for uml into
git://git.kernel.org/pub/scm/linux/kernel/git/viro/um-header.git/ 
including the -idirafter, move of user_constants.h, etc.
Another fun thing: user.h used to be included directly by just about
every userland-side file.  Switched it to -include user.h (for USER_CFLAGS,
of course - not for normal stuff), killed includes, got rid of shitloads
of kern_constants.h includes at the same time.  At which point getting
rid of kern_constants.h became trivial.

Up to Jeff's approval, obviously - *including* -idirafter patch.