From: Andrew Morton <akpm@linux-foundation.org>
To: David VomLehn <dvomlehn@cisco.com>
Cc: stern@rowland.harvard.edu, linux-kernel@vger.kernel.org,
linux-embedded@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [Patch] Wait for console to become available, ver 3
Date: Mon, 20 Apr 2009 15:50:33 -0700 [thread overview]
Message-ID: <20090420155033.a89ad4a0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090420223500.GB11068@cuplxvomd02.corp.sa.net>
On Mon, 20 Apr 2009 15:35:00 -0700
David VomLehn <dvomlehn@cisco.com> wrote:
> On Mon, Apr 20, 2009 at 03:14:00PM -0700, Andrew Morton wrote:
> > On Mon, 20 Apr 2009 17:51:16 -0400 (EDT)
> > Alan Stern <stern@rowland.harvard.edu> wrote:
> ...
> > > What if a subsystem simply doesn't know in advance whether or not it's
> > > going to register a console? Or doesn't know when it has finished
> > > probing all devices (since a new device could be plugged in at any
> > > time)?
> >
> > Fix it. It's trivial to make a sub-driver call back into a higher
> > layer to tell it that it registered a console. Or just do the
> > i_will_be_adding_a_console_soon()/oops_im_not_adding_a_console_after_all()
> > calls from the layer which _does_ know.
>
> In the case of the console, we already have register_console(), which is
> what I'm using. I think your proposal will require adding code all over
> the place. And buses such as USB simply have no way of knowing whether they
> are done enumerating devices. A new device could take hours to come on line.
Add a timeout parameter to i_will_be_adding_a_console_soon(). (This
means that the how-long-to-wait-for policy is probably ahrd-coded into
the kernel which might be a problem).
> > Yes, a boot parameter is "simple" to inplement. But it's ghastly from
> > a usability POV. Especially if you care about boot times. For how
> > long do you delay? The user has to experiment with different delays
> > until he finds the magic number. Then he adds 10% and waits for the
> > inevitable failure reports to come in.
> >
> > It's much better to just get it right, even if that makes it more
> > "complex".
>
> With USB, you just can't *ever* get it right. There is no limit on how
> long a device has to tell you its there. I wish this weren't the case,
> but our good friends in the USB world tell us that we have been lucky
> to have had USB consoles work as long as they have.
Sigh, OK, I appreciate the problem better. But the proposed "solution"
is really quite fragile. I expect that it will only prove usable in
highly controlled hardware setups.
Is my option a) any use?
next prev parent reply other threads:[~2009-04-20 22:54 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 21:31 [Patch] Wait for console to become available, ver 3 David VomLehn
2009-04-17 22:15 ` H. Peter Anvin
2009-04-17 23:12 ` David VomLehn
2009-04-20 21:30 ` Andrew Morton
2009-04-20 21:51 ` Alan Stern
2009-04-20 22:14 ` Andrew Morton
2009-04-20 22:35 ` David VomLehn
2009-04-20 22:50 ` Andrew Morton [this message]
2009-04-20 23:23 ` David VomLehn
2009-04-20 22:53 ` Greg KH
2009-04-20 22:29 ` David VomLehn
2009-04-20 22:35 ` Andrew Morton
2009-04-25 8:16 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420155033.a89ad4a0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dvomlehn@cisco.com \
--cc=linux-embedded@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox