From: Andrew Morton <akpm@linux-foundation.org>
To: Adriano dos Santos Fernandes <adrianosf@uol.com.br>
Cc: mingo@elte.hu, venkatesh.pallipadi@intel.com,
suresh.b.siddha@intel.com, arjan@linux.intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: memory_open cleanup - lookup minor device number from devlist
Date: Mon, 20 Apr 2009 17:01:55 -0700 [thread overview]
Message-ID: <20090420170155.9ff82860.akpm@linux-foundation.org> (raw)
In-Reply-To: <49EBF483.8000908@uol.com.br>
On Mon, 20 Apr 2009 01:05:23 -0300
Adriano dos Santos Fernandes <adrianosf@uol.com.br> wrote:
> memory_open ignores devlist and does a switch for each item, duplicating
> code
> and conditional definitions.
>
> Clean it adding backing_dev_info to devlist and use it to lookup for the
> minor
> device.
The patch looks reasonable, however your email client replaced all tabs
with spaces and I didn't really feel like fixing it all up.
I wonder what the lock_kernel() calls in memory_open() are doing.
next prev parent reply other threads:[~2009-04-21 0:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 4:05 [PATCH] drivers: memory_open cleanup - lookup minor device number from devlist Adriano dos Santos Fernandes
2009-04-21 0:01 ` Andrew Morton [this message]
2009-04-21 0:27 ` Adriano dos Santos Fernandes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090420170155.9ff82860.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adrianosf@uol.com.br \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox