From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753785AbZDUGiz (ORCPT ); Tue, 21 Apr 2009 02:38:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750777AbZDUGip (ORCPT ); Tue, 21 Apr 2009 02:38:45 -0400 Received: from 124x34x33x190.ap124.ftth.ucom.ne.jp ([124.34.33.190]:33491 "EHLO master.linux-sh.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751204AbZDUGio (ORCPT ); Tue, 21 Apr 2009 02:38:44 -0400 Date: Tue, 21 Apr 2009 15:33:37 +0900 From: Paul Mundt To: Mel Gorman Cc: Linux Memory Management List , KOSAKI Motohiro , Christoph Lameter , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Pekka Enberg , Andrew Morton Subject: Re: [PATCH 03/25] Do not check NUMA node ID when the caller knows the node is valid Message-ID: <20090421063337.GB15167@linux-sh.org> Mail-Followup-To: Paul Mundt , Mel Gorman , Linux Memory Management List , KOSAKI Motohiro , Christoph Lameter , Nick Piggin , Linux Kernel Mailing List , Lin Ming , Zhang Yanmin , Peter Zijlstra , Pekka Enberg , Andrew Morton References: <1240266011-11140-1-git-send-email-mel@csn.ul.ie> <1240266011-11140-4-git-send-email-mel@csn.ul.ie> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1240266011-11140-4-git-send-email-mel@csn.ul.ie> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 20, 2009 at 11:19:49PM +0100, Mel Gorman wrote: > Callers of alloc_pages_node() can optionally specify -1 as a node to mean > "allocate from the current node". However, a number of the callers in fast > paths know for a fact their node is valid. To avoid a comparison and branch, > this patch adds alloc_pages_exact_node() that only checks the nid with > VM_BUG_ON(). Callers that know their node is valid are then converted. > > Signed-off-by: Mel Gorman > Reviewed-by: Christoph Lameter For the SLOB NUMA bits: Acked-by: Paul Mundt