From: Jens Axboe <jens.axboe@oracle.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: linux-next@vger.kernel.org, linux-kernel@vger.kernel.org,
viro@zeniv.linux.org.uk, alexb <alexb@vax.1wt.eu>
Subject: Re: [PATCH 1/2] fs/compat_ioctl: fix build when !BLOCK
Date: Tue, 21 Apr 2009 09:32:34 +0200 [thread overview]
Message-ID: <20090421073234.GB4593@kernel.dk> (raw)
In-Reply-To: <1240215264-8096-1-git-send-email-a.beregalov@gmail.com>
On Mon, Apr 20 2009, Alexander Beregalov wrote:
> From: alexb <alexb@localhost.(none)>
>
> In file included from fs/compat_ioctl.c:61:
> include/linux/loop.h:59: error: field 'lo_bio_list' has incomplete type
>
> Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Thanks, applied.
> ---
> fs/compat_ioctl.c | 7 +++----
> 1 files changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/fs/compat_ioctl.c b/fs/compat_ioctl.c
> index 3e87ce4..b83f6bc 100644
> --- a/fs/compat_ioctl.c
> +++ b/fs/compat_ioctl.c
> @@ -58,7 +58,6 @@
> #include <linux/i2c.h>
> #include <linux/i2c-dev.h>
> #include <linux/atalk.h>
> -#include <linux/loop.h>
>
> #include <net/bluetooth/bluetooth.h>
> #include <net/bluetooth/hci.h>
> @@ -68,6 +67,7 @@
> #include <linux/gigaset_dev.h>
>
> #ifdef CONFIG_BLOCK
> +#include <linux/loop.h>
> #include <scsi/scsi.h>
> #include <scsi/scsi_ioctl.h>
> #include <scsi/sg.h>
> @@ -2660,6 +2660,8 @@ HANDLE_IOCTL(SONET_GETFRAMING, do_atm_ioctl)
> HANDLE_IOCTL(SONET_GETFRSENSE, do_atm_ioctl)
> /* block stuff */
> #ifdef CONFIG_BLOCK
> +/* loop */
> +IGNORE_IOCTL(LOOP_CLR_FD)
> /* Raw devices */
> HANDLE_IOCTL(RAW_SETBIND, raw_ioctl)
> HANDLE_IOCTL(RAW_GETBIND, raw_ioctl)
> @@ -2728,9 +2730,6 @@ HANDLE_IOCTL(LPSETTIMEOUT, lp_timeout_trans)
> IGNORE_IOCTL(VFAT_IOCTL_READDIR_BOTH32)
> IGNORE_IOCTL(VFAT_IOCTL_READDIR_SHORT32)
>
> -/* loop */
> -IGNORE_IOCTL(LOOP_CLR_FD)
> -
> #ifdef CONFIG_SPARC
> /* Sparc framebuffers, handled in sbusfb_compat_ioctl() */
> IGNORE_IOCTL(FBIOGTYPE)
> --
> 1.6.2.3
>
--
Jens Axboe
next prev parent reply other threads:[~2009-04-21 7:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1240215264-8096-1-git-send-email-a.beregalov@gmail.com>
2009-04-20 8:23 ` [PATCH 1/2] fs/compat_ioctl: fix build when !BLOCK Alexander Beregalov
2009-04-21 7:32 ` Jens Axboe [this message]
2009-04-21 8:34 ` Alexander Beregalov
2009-04-21 9:21 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090421073234.GB4593@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=a.beregalov@gmail.com \
--cc=alexb@vax.1wt.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).