Re: [PATCH 3/8] tracing: make trace_seq operations available for core kernel

Steven Rostedt
2009-04-15T02:20:07Z

On Tue, 14 Apr 2009, Peter Zijlstra wrote:

> On Tue, 2009-04-14 at 13:23 -0400, Steven Rostedt wrote:
> > +struct trace_seq {
> > + unsigned char buffer[PAGE_SIZE];
> > + unsigned int len;
> > + unsigned int readpos;
> > +};
>
> Would not PAGE_SIZE-2*sizeof(int) be enough? That would make the struct
> fit into a single page and avoid an order-1 allocation.

That may be an option. I've even thought about doing that before. Not sure
why I did not. But we could give it a try.

-- Steve