Re: [PATCH v2] fix sign extension with 1.5TB usb-storage LBD=y

Matthew Wilcox
2009-04-22T11:09:36Z

On Wed, Apr 22, 2009 at 10:32:59AM +0300, Boaz Harrosh wrote:
> These are actually aligned access it might be worth sacrificing a cast
> to be32/64 for sake of speed.

"for sake of speed"? How often do you think we ask a device how large
it is? How much overhead do you think is incurred by the unaligned code
if the data happens to be aligned?

--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."