From: Greg KH <greg@kroah.com>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb/core/hub.c: fix sparse warnings
Date: Tue, 21 Apr 2009 22:51:18 -0700 [thread overview]
Message-ID: <20090422055118.GE9009@kroah.com> (raw)
In-Reply-To: <BD79186B4FD85F4B8E60E381CAEE1909015F8DF9@mi8nycmail19.Mi8.com>
On Wed, Apr 15, 2009 at 09:44:44PM -0400, H Hartley Sweeten wrote:
> Fix sparse warning in drivers/usb/core/hub.c.
>
> warning: symbol 'temp' shadows an earlier one
Odd, I'm not seeing that when I run sparse on this file. What version
of sparse are you using?
Also, the patch is line-wrapped and you delete a lot of trailing spaces.
Deleting trailing spaces is nice, but that's not what you said you were
doing here in this patch, so I'm going to have to drop it.
thanks,
greg k-h
next prev parent reply other threads:[~2009-04-22 6:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-16 1:44 [PATCH] usb/core/hub.c: fix sparse warnings H Hartley Sweeten
2009-04-22 5:51 ` Greg KH [this message]
2009-04-22 17:25 ` H Hartley Sweeten
2009-04-22 20:03 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422055118.GE9009@kroah.com \
--to=greg@kroah.com \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox