From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755411AbZDVGJ0 (ORCPT ); Wed, 22 Apr 2009 02:09:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752995AbZDVGIy (ORCPT ); Wed, 22 Apr 2009 02:08:54 -0400 Received: from kroah.org ([198.145.64.141]:37197 "EHLO coco.kroah.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752727AbZDVGIx (ORCPT ); Wed, 22 Apr 2009 02:08:53 -0400 Date: Tue, 21 Apr 2009 22:51:18 -0700 From: Greg KH To: H Hartley Sweeten Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] usb/core/hub.c: fix sparse warnings Message-ID: <20090422055118.GE9009@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.19 (2009-01-05) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2009 at 09:44:44PM -0400, H Hartley Sweeten wrote: > Fix sparse warning in drivers/usb/core/hub.c. > > warning: symbol 'temp' shadows an earlier one Odd, I'm not seeing that when I run sparse on this file. What version of sparse are you using? Also, the patch is line-wrapped and you delete a lot of trailing spaces. Deleting trailing spaces is nice, but that's not what you said you were doing here in this patch, so I'm going to have to drop it. thanks, greg k-h