public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Linus Torvalds <torvalds@linux-foundation.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Alexander Beregalov <a.beregalov@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	Peter Osterlund <petero2@telia.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency
Date: Wed, 22 Apr 2009 08:38:33 +0200	[thread overview]
Message-ID: <20090422063833.GA23258@elte.hu> (raw)
In-Reply-To: <20090422062053.GA20960@elte.hu>


* Ingo Molnar <mingo@elte.hu> wrote:

> A last-minute build error slipped through:
>
>   In file included from fs/compat_ioctl.c:105:
>   include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ‘mempool_t’

Caused by:

  1ba0c7d: fs/compat_ioctl: fix build when !BLOCK

fixed by the patch below. The build error itself triggers with 
!BLOCK

	Ingo

------------------>
>From f8b664b0e6ad3369a998379e7f87297082d04bef Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 22 Apr 2009 08:29:40 +0200
Subject: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

A change to the order of header files in fs/compat_ioctl.c
unearthed a dormant header file dependency bug:

  In file included from fs/compat_ioctl.c:105:
  include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ‘mempool_t’

pktcdvd.h relies on mempool_t but does not include mempool.h.
This worked until now accidentally: due to other headers including
mempool.h in compat_ioctl.c (and all other pktcdvd.h using sites).
But once the header file broke this implicit dependency got
uncovered and an uncleanliness turned into a build failure.

Add mempool.h to pktcdvd.h.

[ Impact: fix build on !CONFIG_BLOCK ]

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/pktcdvd.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/pktcdvd.h b/include/linux/pktcdvd.h
index 04b4d73..9cabc20 100644
--- a/include/linux/pktcdvd.h
+++ b/include/linux/pktcdvd.h
@@ -112,6 +112,7 @@ struct pkt_ctrl_command {
 #include <linux/completion.h>
 #include <linux/cdrom.h>
 #include <linux/kobject.h>
+#include <linux/mempool.h>
 #include <linux/sysfs.h>
 
 /* default bio write queue congestion marks */

  reply	other threads:[~2009-04-22  6:38 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22  3:27 Linus 2.6.30-rc3 Linus Torvalds
2009-04-22  6:20 ` Ingo Molnar
2009-04-22  6:38   ` Ingo Molnar [this message]
2009-04-22  6:39     ` [PATCH] include/linux/pktcdvd.h: add mempool.h dependency Jens Axboe
2009-04-22  6:54       ` Ingo Molnar
2009-04-22  6:58         ` Jens Axboe
2009-04-22  7:06           ` Ingo Molnar
2009-04-22  6:42     ` Ingo Molnar
2009-04-22  9:24 ` Linus 2.6.30-rc3 Denys Vlasenko
2009-04-24  9:51 ` [BUG] 2.6.30-rc3: BUG triggered on some hugepage usages Mel Gorman
2009-04-24 15:24   ` Michael Ellerman
2009-04-30 20:59     ` Mel Gorman
2009-04-30 21:48       ` Benjamin Herrenschmidt
2009-05-18 17:13         ` Mel Gorman
2009-05-18 17:26           ` Linus Torvalds
2009-04-27  8:15   ` Benjamin Herrenschmidt
2009-04-24 17:52 ` [BUG] 2.6.30-rc3: bnx2 failing to load firmware Mel Gorman
2009-04-24 18:31   ` Frans Pop
2009-04-24 18:37     ` Linus Torvalds
2009-04-24 19:02       ` Frans Pop
2009-04-27 12:34   ` Martin Knoblauch
2009-04-27 13:33     ` Mel Gorman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422063833.GA23258@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.beregalov@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=petero2@telia.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox