Re: [PATCH] include/linux/pktcdvd.h: add mempool.h dependency

[Jens Axboe <jens.axboe@oracle.com>]

On Wed, Apr 22 2009, Ingo Molnar wrote:
> 
> * Jens Axboe <jens.axboe@oracle.com> wrote:
> 
> > On Wed, Apr 22 2009, Ingo Molnar wrote:
> > > 
> > > * Ingo Molnar <mingo@elte.hu> wrote:
> > > 
> > > > A last-minute build error slipped through:
> > > >
> > > >   In file included from fs/compat_ioctl.c:105:
> > > >   include/linux/pktcdvd.h:285: error: expected specifier-qualifier-list before ???mempool_t???
> > > 
> > > Caused by:
> > > 
> > >   1ba0c7d: fs/compat_ioctl: fix build when !BLOCK
> > > 
> > > fixed by the patch below. The build error itself triggers with 
> > > !BLOCK
> > 
> > This fix is already queued up in the block tree, it just didn't 
> > make -rc3.
> 
> ah, i see - it was posted two days ago:
> 
>   [PATCH 2/2] pktcdvd.h should include mempool.h
> 
> but the fix should have been queued up in the tree pushing the 
> compat_ioctl.c change (Viro's). Could have been avoided by insisting 
> on a fuller explanation in the changelog instead of just a "Fix this 
> build error" line.

I didn't realize it was a new build error, so just added both the
patches to my lineup. I see that 1/2 went in through Viro's tree, not
sure why he didn't pick up 2/2 as well.

I'll make sure to get it upstream today.

-- 
Jens Axboe