From: Ingo Molnar <mingo@elte.hu>
To: Dmitry Adamushko <dmitry.adamushko@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Peter Oruba <peter.oruba@amd.com>,
Arjan van de Ven <arjan@infradead.org>,
Hugh Dickins <hugh@veritas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86 microcode: work_on_cpu and cleanup of the synchronization logic
Date: Wed, 22 Apr 2009 12:18:11 +0200 [thread overview]
Message-ID: <20090422101811.GA1115@elte.hu> (raw)
In-Reply-To: <1240344440.5861.10.camel@earth>
* Dmitry Adamushko <dmitry.adamushko@gmail.com> wrote:
> +static long collect_cpu_info_local(void *arg)
> +{
> + struct collect_for_cpu *cfc = arg;
> +
> + BUG_ON(cfc->cpu != raw_smp_processor_id());
> +
> + return microcode_ops->collect_cpu_info(cfc->cpu, cfc->cpu_sig);
> +}
> +
> +static int collect_cpu_info_on_target(int cpu, struct cpu_signature *cpu_sig)
> +{
> + struct collect_for_cpu cfc = { .cpu_sig = cpu_sig, .cpu = cpu };
> +
> + return work_on_cpu(cpu, collect_cpu_info_local, &cfc);
> +}
Couldnt this be done without work_on_cpu(), by using
smp_call_function()?
Ingo
next prev parent reply other threads:[~2009-04-22 10:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-20 20:16 [PATCH] x86 microcode: work_on_cpu and cleanup of the synchronization logic Dmitry Adamushko
2009-04-21 8:29 ` Ingo Molnar
2009-04-21 20:07 ` Dmitry Adamushko
2009-04-21 20:09 ` Dmitry Adamushko
2009-04-22 10:18 ` Ingo Molnar [this message]
2009-04-22 10:33 ` Dmitry Adamushko
2009-04-22 10:36 ` Ingo Molnar
2009-04-22 10:34 ` Ingo Molnar
2009-04-22 22:24 ` Dmitry Adamushko
2009-04-23 8:27 ` Ingo Molnar
2009-04-23 8:55 ` Dmitry Adamushko
2009-04-23 18:03 ` Hugh Dickins
2009-04-23 22:16 ` Dmitry Adamushko
2009-04-24 12:23 ` Hugh Dickins
2009-04-24 14:11 ` Dmitry Adamushko
2009-04-24 15:30 ` Hugh Dickins
2009-04-24 17:01 ` Dmitry Adamushko
2009-04-24 18:00 ` Hugh Dickins
2009-04-25 10:30 ` Dmitry Adamushko
2009-05-06 22:30 ` Dmitry Adamushko
2009-05-07 8:08 ` Dmitry Adamushko
2009-05-11 21:48 ` [PATCH, -tip] x86 microcode: smp_call_function_single() instead of set_cpus_allowed, cleanup of sync. logic Dmitry Adamushko
2009-05-12 8:27 ` [tip:x86/microcode] x86: microcode: use smp_call_function_single instead of set_cpus_allowed, cleanup of synchronization logic tip-bot for Dmitry Adamushko
2009-05-12 8:39 ` tip-bot for Dmitry Adamushko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422101811.GA1115@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andreas.herrmann3@amd.com \
--cc=arjan@infradead.org \
--cc=dmitry.adamushko@gmail.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.oruba@amd.com \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).