From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Zhaolei <zhaolei@cn.fujitsu.com>,
Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH 1/2 v3] tracing/events: provide string with undefined size support
Date: Wed, 22 Apr 2009 12:41:01 +0200 [thread overview]
Message-ID: <20090422104101.GF1115@elte.hu> (raw)
In-Reply-To: <alpine.DEB.2.00.0904211820410.9714@gandalf.stny.rr.com>
* Steven Rostedt <rostedt@goodmis.org> wrote:
> On Wed, 22 Apr 2009, Frederic Weisbecker wrote:
>
> > Thanks!
> > Then, may be I should wait for Ingo's pull (if he accepts)
> > before sending a delta to add the parenthesis around __get_str().
>
> It would probably be better to just make the fix now. Just put the
> fix in a separate branch to avoid race conditions (if Ingo already
> did a pull ;-)
Yeah - doing a -v2 (-v3, -v4 ;-) COW branch and then removing them
once they served their purpose does the trick here.
While i generally dont get surprised (negatively ;) by seeing more
(or less) stuff in a branch than expected from the pull request (i
review it all anyway), it's good to practice the COW pull workflow
so that if you send stuff to Linus or others who expect COW there's
no mistakes.
Ingo
next prev parent reply other threads:[~2009-04-22 10:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-19 5:01 [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Frederic Weisbecker
2009-04-19 5:01 ` [PATCH 1/2 v3] tracing/events: provide string with undefined size support Frederic Weisbecker
2009-04-19 6:15 ` Li Zefan
2009-04-19 12:35 ` Frederic Weisbecker
2009-04-21 18:16 ` Frederic Weisbecker
2009-04-21 18:33 ` Steven Rostedt
2009-04-21 21:58 ` Steven Rostedt
2009-04-21 22:00 ` Steven Rostedt
2009-04-21 22:12 ` Frederic Weisbecker
2009-04-21 22:21 ` Steven Rostedt
2009-04-21 23:32 ` [PATCH][GIT-PULL] tracing/events: protect __get_str() Frederic Weisbecker
2009-04-22 10:25 ` Ingo Molnar
2009-04-22 10:41 ` Ingo Molnar [this message]
2009-04-19 5:01 ` [PATCH 2/2 v3] tracing/lock: provide lock_acquired event support for dynamic size string Frederic Weisbecker
2009-04-21 21:59 ` Steven Rostedt
2009-04-19 6:14 ` [PATCH 0/2 v3] [GIT PULL] tracing/events: add the __string field Li Zefan
2009-04-19 12:34 ` Frederic Weisbecker
2009-04-19 13:49 ` [PATCH] tracing/core: Add current context on tracing recursion warning Frederic Weisbecker
2009-04-19 14:01 ` Ingo Molnar
2009-04-19 14:22 ` Frederic Weisbecker
2009-04-19 18:45 ` Ingo Molnar
2009-04-19 18:48 ` Frédéric Weisbecker
2009-04-19 18:47 ` Ingo Molnar
2009-04-19 17:28 ` Frederic Weisbecker
2009-04-20 0:37 ` Li Zefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422104101.GF1115@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
--cc=zhaolei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox