From: Andrea Righi <righi.andrea@gmail.com>
To: Gui Jianfeng <guijianfeng@cn.fujitsu.com>
Cc: Paul Menage <menage@google.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
agk@sourceware.org, akpm@linux-foundation.org, axboe@kernel.dk,
baramsori72@gmail.com, Carl Henrik Lunde <chlunde@ping.uio.no>,
dave@linux.vnet.ibm.com, Divyesh Shah <dpshah@google.com>,
eric.rannaud@gmail.com, fernando@oss.ntt.co.jp,
Hirokazu Takahashi <taka@valinux.co.jp>,
Li Zefan <lizf@cn.fujitsu.com>,
matt@bluehost.com, dradford@bluehost.com, ngupta@google.com,
randy.dunlap@oracle.com, roberto@unbit.it,
Ryo Tsuruta <ryov@valinux.co.jp>,
Satoshi UCHIDA <s-uchida@ap.jp.nec.com>,
subrata@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp,
Nauman Rafique <nauman@google.com>,
fchecconi@gmail.com, paolo.valente@unimore.it,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] cgroup: io-throttle controller (v14)
Date: Wed, 22 Apr 2009 14:43:29 +0200 [thread overview]
Message-ID: <20090422124328.GA32007@linux> (raw)
In-Reply-To: <49EE6E3C.8050409@cn.fujitsu.com>
On Wed, Apr 22, 2009 at 09:09:16AM +0800, Gui Jianfeng wrote:
> Andrea Righi wrote:
> > On Tue, Apr 21, 2009 at 09:16:22AM +0800, Gui Jianfeng wrote:
> >> Andrea Righi wrote:
> >>> On Mon, Apr 20, 2009 at 04:39:29PM +0800, Gui Jianfeng wrote:
> >>>> Andrea Righi wrote:
> >>>> ...
> >>>>> Implementation
> >>>>> ~~~~~~~~~~~~~~
> >>>>> Patchset against latest Linus' git:
> >>>>>
> >>>>> [PATCH 0/7] cgroup: block device IO controller (v14)
> >>>>> [PATCH 1/7] io-throttle documentation
> >>>>> [PATCH 2/7] res_counter: introduce ratelimiting attributes
> >>>>> [PATCH 3/7] page_cgroup: provide a generic page tracking infrastructure
> >>>>> [PATCH 4/7] io-throttle controller infrastructure
> >>>>> [PATCH 5/7] kiothrottled: throttle buffered (writeback) IO
> >>>>> [PATCH 6/7] io-throttle instrumentation
> >>>>> [PATCH 7/7] export per-task io-throttle statistics to userspace
> >>>> Hi Andrea,
> >>>>
> >>>> I'd like to have a try this patchset, would you tell what's the kernel version
> >>>> and bio-cgroup version based on?
> >>>>
> >>> Latest Linus' git is the kernel and bio-cgroup v7 (from
> >>> http://people.valinux.co.jp/~ryov/bio-cgroup/).
> >> Sorry, I still can't apply it...
> >>
> >> [root@localhost linux-2.6.30-rc1]# patch -p1 --dry-run < ../cgroup-io-throttle-v14.patch patching file Documentation/cgroups/io-throttle.txt
> >> patching file block/Makefile
> >> patching file block/blk-core.c
> >> patching file block/blk-io-throttle.c
> >> patching file block/kiothrottled.c
> >> patching file fs/aio.c
> >> patching file fs/buffer.c
> >> Hunk #1 FAILED at 36.
> >> Hunk #2 FAILED at 669.
> >> 2 out of 2 hunks FAILED -- saving rejects to file fs/buffer.c.rej
> >> patching file fs/proc/base.c
> >> patching file include/linux/blk-io-throttle.h
> >> patching file include/linux/cgroup_subsys.h
> >> Hunk #1 succeeded at 49 (offset 6 lines).
> >> patching file include/linux/memcontrol.h
> >> Reversed (or previously applied) patch detected! Assume -R? [n] n
> >> Apply anyway? [n] n
> >> Skipping patch.
> >> 2 out of 2 hunks ignored -- saving rejects to file include/linux/memcontrol.h.rej
> >> patching file include/linux/mmzone.h
> >> Hunk #1 FAILED at 607.
> >> Hunk #2 FAILED at 958.
> >> ...
> >
> > Could you checkout the latest Linus' git?
> >
> > $ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6
> >
> > Or at least try with 2.6.30-rc2. It should apply cleanly also to this
> > version.
>
> Yes, I tried them all, but didn't work. :(
> Would you try "cgroup-io-throttle-v14.patch" too?
It works for me:
$ git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6
$ cd linux-2.6
$ wget http://download.systemimager.org/~arighi/linux/patches/io-throttle/cgroup-io-throttle-v14.patch
$ git apply cgroup-io-throttle-v14.patch
(no error reported)
The same for v13.
-Andrea
next prev parent reply other threads:[~2009-04-22 12:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-18 21:37 [PATCH 0/7] cgroup: io-throttle controller (v14) Andrea Righi
2009-04-20 8:39 ` Gui Jianfeng
2009-04-20 14:48 ` Andrea Righi
2009-04-21 1:16 ` Gui Jianfeng
2009-04-21 9:58 ` Andrea Righi
2009-04-22 1:09 ` Gui Jianfeng
2009-04-22 12:43 ` Andrea Righi [this message]
2009-04-23 2:58 ` Gui Jianfeng
2009-04-23 10:14 ` Andrea Righi
2009-04-24 1:10 ` Gui Jianfeng
2009-04-24 8:13 ` Andrea Righi
-- strict thread matches above, loose matches on Subject: below --
2009-04-18 21:38 Andrea Righi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422124328.GA32007@linux \
--to=righi.andrea@gmail.com \
--cc=agk@sourceware.org \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=balbir@linux.vnet.ibm.com \
--cc=baramsori72@gmail.com \
--cc=chlunde@ping.uio.no \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=dpshah@google.com \
--cc=dradford@bluehost.com \
--cc=eric.rannaud@gmail.com \
--cc=fchecconi@gmail.com \
--cc=fernando@oss.ntt.co.jp \
--cc=guijianfeng@cn.fujitsu.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=matt@bluehost.com \
--cc=menage@google.com \
--cc=nauman@google.com \
--cc=ngupta@google.com \
--cc=paolo.valente@unimore.it \
--cc=randy.dunlap@oracle.com \
--cc=roberto@unbit.it \
--cc=ryov@valinux.co.jp \
--cc=s-uchida@ap.jp.nec.com \
--cc=subrata@linux.vnet.ibm.com \
--cc=taka@valinux.co.jp \
--cc=yoshikawa.takuya@oss.ntt.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).